aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 45104: Use chmod+x to make termos_runner.pex executable
Date Tue, 22 Mar 2016 01:02:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45104/#review124697
-----------------------------------------------------------



Sorry for the delay on this. After you filed the pull request, I investigated a bit what will
be required once Mesos 0.30.0 lands: https://issues.apache.org/jira/browse/AURORA-1632. I
think the problem goes beyond the failure to find `sys.executable` when $PATH is not set.
As even after switching back to chmod+x on the runner, the task failed further down the stack.

I suspect the fix for Mesos 0.30.0 will be to set our own $PATH which should allow `sys.executable`
to continue working and will allow any tasks users have running which have come to rely on
Thermos setting it for them to behave as expected. The problem is, I haven't had time to figure
out what we should set $PATH to yet ;) (anyone have any thoughts?).

I know this is probably more info than you bargained for when you opened what seemed like
a simple pull request. I'm not opposed to accepting this patch (with a TODO to restore `sys.executable`
when we figure out what to do about setting $PATH) if it unblocks your use case, but can you
confirm that you're actually able to run the Mesos agent with `--executor_environment_variables='{}'`
and still launch tasks?

- Joshua Cohen


On March 21, 2016, 1:21 p.m., Pierre Cheynier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45104/
> -----------------------------------------------------------
> 
> (Updated March 21, 2016, 1:21 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> When using `--executor_environment_variables` without explicitely
> passing LD_LIBRARY_PATH, `sys.executable` returns an empty string
> resulting in a '[Errno 13] Permission denied' error for every launched
> task.
> 
> Moreover, it seems that this feature is coming in 0.30: "Executors no
> longer inherit environment variables from the agent".
> 
> This patch partially revert back 07ce21d where chmod_x method was
> removed in favor of using sys.executable.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 3896e3841562600379705dbf78a6f62728246348

> 
> Diff: https://reviews.apache.org/r/45104/diff/
> 
> 
> Testing
> -------
> 
> Make Aurora run on CentOS7
> 
> 
> Thanks,
> 
> Pierre Cheynier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message