aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Amol Deshmukh <a...@apache.org>
Subject Review Request 45115: AURORA-1642: Thermos runner finalization broken.
Date Mon, 21 Mar 2016 18:32:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/
-----------------------------------------------------------

Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Repository: aurora


Description
-------

AURORA-1642: Fix for broken finalization in Thermos runner.


Diffs
-----

  src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7

  src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5


Diff: https://reviews.apache.org/r/45115/diff/


Testing
-------

# End to end tests
```
$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***
```

# Python unit tests
```
$ ./pants test src/test/python::
...
                      663 passed, 5 skipped, 1 warnings in 180.34 seconds

```

# Also tested using a test job in vagrant to ensure that "final" processes are executed as
expected using this job definition:
https://gist.github.com/adeshmukh/697d013dec64498a3942


Thanks,

Amol Deshmukh


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message