aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 45042: Add ACL support for announcer
Date Mon, 21 Mar 2016 18:01:49 GMT


> On March 19, 2016, 6:46 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/executor/common/announcer.py, line 153
> > <https://reviews.apache.org/r/45042/diff/2/?file=1306943#file1306943line153>
> >
> >     -1 on the approach of logging and moving forward without auth when errors are
encountered.  these should all be fatal

+1

It's a common pattern in the rest of the code too. It's best that these errors are fatal so
the task can be rescheduled elsewhere and operators get a crude signal for a possible misconfiguration.
This current setup enables for silent failures which makes operating Mesos/Aurora difficult.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45042/#review124431
-----------------------------------------------------------


On March 18, 2016, 2:57 p.m., Kunal Thakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45042/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 2:57 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add ACL support for announcer
> https://issues.apache.org/jira/browse/AURORA-1643
> 
> Adding support for service discovery ZK authentication. ZK authentication secrets should
be stored in a file as json (as follows):
> ```json
> {
>   "scheme": "<scheme>",
>   "credential": "<credential>",
> 	"permissions": {
> 	  "read": <bool>,
> 	  "write": <bool>,
> 	  "create": <bool>,
> 	  "delete": <bool>,
> 	  "admin": <bool>,
> 	  "all": <bool>
> 	}
> }
> ```
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 6634506108c346f8c23b2da7cc8d20d09d07d590

>   src/main/python/apache/aurora/executor/common/announcer.py 79a9cfb6ac3a8444f09fb3658e6e859e06941ba4

>   src/test/python/apache/aurora/executor/common/test_announcer.py 142b58d5e577c9f4b8e2ae8473cffdea94eba21f

> 
> Diff: https://reviews.apache.org/r/45042/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message