aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 45055: Fix flickering of the Aurora logo on refresh.
Date Sat, 19 Mar 2016 00:05:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45055/#review124331
-----------------------------------------------------------



Master (b24619b) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 18, 2016, 10:14 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45055/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 10:14 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Refreshing a subpage of /scheduler in Chrome temporarily resize the Aurora
> logo. This seems to be due to us loading all scripts and styles in the <body>
> after first rending the logo.
> 
> By loading all scripts in the header using the `defer` attribute, scripts are
> only executed after the entire document has been loaded. They are executed in
> order.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/scheduler/index.html 383ca43dfc14448b67181e9d94dd805ac1bbfaa7

> 
> Diff: https://reviews.apache.org/r/45055/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message