aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kunal Thakar <kun...@gmail.com>
Subject Re: Review Request 44532: Allow overriding hostname before announcing
Date Thu, 17 Mar 2016 18:04:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/
-----------------------------------------------------------

(Updated March 17, 2016, 6:04 p.m.)


Review request for Aurora, John Sirois, Stephan Erb, and Bill Farner.


Changes
-------

Test is not failing locally. @ReviewBot retry


Repository: aurora


Description
-------

Allow overriding hostname before announcing (https://issues.apache.org/jira/browse/AURORA-1611)


Diffs (updated)
-----

  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py f82858c528808d2a9e77bb56f16e897cfb5bbe73

  src/main/python/apache/aurora/executor/common/announcer.py 34e36e0a59093468a8934f58bacb68512949347c

  src/test/python/apache/aurora/executor/common/test_announcer.py f4032c7302f4733ab5670322b1905102c200f1c9


Diff: https://reviews.apache.org/r/44532/diff/


Testing
-------

Tested on vagrant with a wrapper for the executor


Thanks,

Kunal Thakar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message