aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 44871: Speed up Vagrant provisioning by using a custom base box.
Date Thu, 17 Mar 2016 18:01:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/#review124062
-----------------------------------------------------------



Master (6537581) is red with this patch.
  ./build-support/jenkins/build.sh

                           proxy_driver = ProxyDriver()
                           with temporary_dir() as checkpoint_root:
                             te = AuroraExecutor(
                     >           runner_provider=make_provider(checkpoint_root),
                                 sandbox_provider=DefaultTestSandboxProvider())
                     
                     src/test/python/apache/aurora/executor/test_thermos_executor.py:580:

                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     src/test/python/apache/aurora/executor/test_thermos_executor.py:193:
in make_provider
                         pex_location=thermos_runner_path(),
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     build = True
                     
                         def thermos_runner_path(build=True):
                           if not build:
                             return getattr(thermos_runner_path, 'value', None)
                         
                           if not hasattr(thermos_runner_path, 'value'):
                             pex_dir = safe_mkdtemp()
                     >       assert subprocess.call(["./pants", "--pants-distdir=%s"
% pex_dir, "binary",
                               "src/main/python/apache/thermos/runner:thermos_runner"])
== 0
                     E       assert 1 == 0
                     E        +  where 1 = <function call at 0x7f83cd239b18>(['./pants',
'--pants-distdir=/tmp/user/10021/tmp0RrjAm', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])
                     E        +    where <function call at 0x7f83cd239b18>
= subprocess.call
                     
                     src/test/python/apache/aurora/executor/test_thermos_executor.py:185:
AssertionError
                     -------------- Captured stderr call --------------
                     Traceback (most recent call last):
                       File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants",
line 7, in <module>
                         from pants.bin.pants_exe import main
                     ImportError: No module named pants.bin.pants_exe
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml

                      16 failed, 639 passed, 5 skipped, 1 warnings, 8 error in 216.63
seconds 
                     
FAILURE


18:00:57 04:20   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 17, 2016, 5:28 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44871/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 5:28 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Relevant docs on packer can be found here: https://www.packer.io/docs/
> 
> To support this, i have created the [`apache-aurora` org](https://atlas.hashicorp.com/apache-aurora).
 If we move forward with this patch, i will be looking to add other committers to the org
and improve the bus factor.
> 
> 
> Diffs
> -----
> 
>   .gitignore 1af09a251b3f76c13813033d32aa7efba9aef304 
>   Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd 
>   build-support/packer/README.md PRE-CREATION 
>   build-support/packer/aurora.json PRE-CREATION 
>   build-support/packer/build.sh PRE-CREATION 
>   examples/vagrant/mesos_config/README.md PRE-CREATION 
>   examples/vagrant/mesos_config/etc_mesos-master/ip PRE-CREATION 
>   examples/vagrant/mesos_config/etc_mesos-master/roles PRE-CREATION 
>   examples/vagrant/mesos_config/etc_mesos-slave/containerizers PRE-CREATION 
>   examples/vagrant/mesos_config/etc_mesos-slave/hostname PRE-CREATION 
>   examples/vagrant/mesos_config/etc_mesos-slave/ip PRE-CREATION 
>   examples/vagrant/mesos_config/etc_mesos-slave/modules PRE-CREATION 
>   examples/vagrant/mesos_config/etc_mesos-slave/resource_estimator PRE-CREATION 
>   examples/vagrant/mesos_config/etc_mesos-slave/resources PRE-CREATION 
>   examples/vagrant/mesos_config/etc_mesos-slave/work_dir PRE-CREATION 
>   examples/vagrant/provision-dev-cluster.sh df33a30c1dcc0ea832899c849be05fe9deb47433

>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf eec5ee3a2f041ae25fa664b80004e27ed8b5e2b0

>   examples/vagrant/upstart/aurora-scheduler.conf 7e10b2c7690087bb150a9033cbd576ab82b1b185

>   examples/vagrant/upstart/mesos-master.conf a2ed953d871a7b28444a188ee0fc152853c5b088

>   examples/vagrant/upstart/mesos-slave.conf d97fa1fcf99580ef3f0997e9c78cb9775b91a818

> 
> Diff: https://reviews.apache.org/r/44871/diff/
> 
> 
> Testing
> -------
> 
> I can run `vagrant up`, end-to-end tests pass.
> 
> Reviewers - you can do this as well by applying the patch.  You will observe a long fetch
on the first run (much like you would with the current repo if you wiped your local vagrant
boxes).  However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast,
about 1m30s for me.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message