aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <wfar...@apache.org>
Subject Re: Review Request 44871: Speed up Vagrant provisioning by using a custom base box.
Date Thu, 17 Mar 2016 03:51:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/
-----------------------------------------------------------

(Updated March 16, 2016, 8:51 p.m.)


Review request for Aurora, John Sirois and Zameer Manji.


Changes
-------

Addressed startup issues that jsirois and i encountered.  This was an ordering issue, where
init scripts from the mesos package were being used rather than the upstart scripts in our
repo.  In the latest revision of the patch, i dropped our upstart config and instead configure
the package we are consume.  

Unfortunately there's an issue i encountered down the road related to docker/devicemapper.
 This should not stall review, however.


Repository: aurora


Description (updated)
-------

_READY FOR REVIEW BUT NOT SUBMISSION - END-TO-END TESTS FAIL_

Relevant docs on packer can be found here: https://www.packer.io/docs/

To support this, i have created the [`apache-aurora` org](https://atlas.hashicorp.com/apache-aurora).
 If we move forward with this patch, i will be looking to add other committers to the org
and improve the bus factor.


Diffs (updated)
-----

  .gitignore 1af09a251b3f76c13813033d32aa7efba9aef304 
  Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd 
  build-support/packer/README.md PRE-CREATION 
  build-support/packer/aurora.json PRE-CREATION 
  build-support/packer/build.sh PRE-CREATION 
  examples/vagrant/mesos_config/etc_mesos-master/ip PRE-CREATION 
  examples/vagrant/mesos_config/etc_mesos-master/roles PRE-CREATION 
  examples/vagrant/mesos_config/etc_mesos-slave/containerizers PRE-CREATION 
  examples/vagrant/mesos_config/etc_mesos-slave/hostname PRE-CREATION 
  examples/vagrant/mesos_config/etc_mesos-slave/ip PRE-CREATION 
  examples/vagrant/mesos_config/etc_mesos-slave/modules PRE-CREATION 
  examples/vagrant/mesos_config/etc_mesos-slave/resource_estimator PRE-CREATION 
  examples/vagrant/mesos_config/etc_mesos-slave/resources PRE-CREATION 
  examples/vagrant/mesos_config/etc_mesos-slave/work_dir PRE-CREATION 
  examples/vagrant/provision-dev-cluster.sh df33a30c1dcc0ea832899c849be05fe9deb47433 
  examples/vagrant/upstart/aurora-scheduler-kerberos.conf eec5ee3a2f041ae25fa664b80004e27ed8b5e2b0

  examples/vagrant/upstart/aurora-scheduler.conf 7e10b2c7690087bb150a9033cbd576ab82b1b185

  examples/vagrant/upstart/mesos-master.conf a2ed953d871a7b28444a188ee0fc152853c5b088 
  examples/vagrant/upstart/mesos-slave.conf d97fa1fcf99580ef3f0997e9c78cb9775b91a818 

Diff: https://reviews.apache.org/r/44871/diff/


Testing (updated)
-------

I can run `vagrant up`, end-to-end tests pass.

Reviewers - you can do this as well by applying the patch.  You will observe a long fetch
on the first run (much like you would with the current repo if you wiped your local vagrant
boxes).  However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast,
about 1m30s for me.


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message