aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <wfar...@apache.org>
Subject Re: Review Request 44532: Allow overriding hostname before announcing
Date Thu, 17 Mar 2016 01:37:49 GMT


> On March 16, 2016, 6:33 p.m., Bill Farner wrote:
> > Just one nit from me, otherwise LGTM!

Oh, nearly forgot - please add docs!

- Add a small section and blurb here describing how this would be used (i.e. write the doc
you wish you had read before contributing the patch)
   https://github.com/apache/aurora/blob/master/docs/configuration-reference.md#announcer-objects
- Add a line to `RELEASE_NOTES.md` about the arg being added, and link to the doc section
above


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review123965
-----------------------------------------------------------


On March 16, 2016, 12:43 p.m., Kunal Thakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 12:43 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Stephan Erb, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Allow overriding hostname before announcing (https://issues.apache.org/jira/browse/AURORA-1611)
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py f82858c528808d2a9e77bb56f16e897cfb5bbe73

>   src/main/python/apache/aurora/executor/common/announcer.py 34e36e0a59093468a8934f58bacb68512949347c

>   src/test/python/apache/aurora/executor/common/test_announcer.py f4032c7302f4733ab5670322b1905102c200f1c9

> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> -------
> 
> Tested on vagrant with a wrapper for the executor
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message