aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <wfar...@apache.org>
Subject Re: Review Request 44827: Do not split the shell command string passed into shell health check script
Date Tue, 15 Mar 2016 02:51:58 GMT


> On March 14, 2016, 7:51 p.m., Bill Farner wrote:
> > Before i land this - can you file a bug and link against this patch?  It will be
helpful for release tracking and as a trail if anybody else bumps into this.

s/i/we/, for some reason i thought i was the only reviewer.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44827/#review123578
-----------------------------------------------------------


On March 14, 2016, 7:10 p.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44827/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 7:10 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixing bug where you could not pass in shell command into health checker with environment
variables. When environment variable assignement was passed in, only that part would get executed
and 0 would always get returned.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/common/health_check/shell.py bf63d936b3044dfa97a787938b643a52497f2d79

>   src/test/python/apache/aurora/common/health_check/test_shell.py 8d3a3e4e259e1ff699854aeb2434ac21f38e49ea

> 
> Diff: https://reviews.apache.org/r/44827/diff/
> 
> 
> Testing
> -------
> 
> Unit tests + end_to_end test.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message