aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Review Request 44726: Limit the scope of hot-reload resources.
Date Fri, 11 Mar 2016 21:25:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44726/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen and Bill Farner.


Repository: aurora


Description
-------

This limits the hot-reload resources to those found under
dist/resources/main/scheduler (all the UI resources), in order to
prevent confusion when rebuilding the scheduler for use in the vagrant
vm with non-ui resource changes (say to the db schema.sql).

 docs/developing-aurora-scheduler.md |  8 ++++----
 examples/vagrant/aurorabuild.sh     | 11 ++++++++++-
 2 files changed, 14 insertions(+), 5 deletions(-)


Diffs
-----

  docs/developing-aurora-scheduler.md a7a929e0c1bc58070603d2ff7736a4e264f9b0ec 
  examples/vagrant/aurorabuild.sh 92066e8461246ca76c00b273960dec85a5e94338 

Diff: https://reviews.apache.org/r/44726/diff/


Testing
-------

I manually tested resilience by deleting `/vagrant/dist/.hot_resources`
and `/vagrant/dist/.hot_resources/scheduler` and running
`aurorabuild scheduler` after each.  I also double checked the
head-of-the `CLASSPATH` trick by checking the classpath:
`-classpath /vagrant/dist/.hot_resources:/home/...` and live editing
`dist/resources/main/scheduler/assets/index.html` from outside the vm
and reloading that root links page.


Thanks,

John Sirois


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message