aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <wfar...@apache.org>
Subject Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.
Date Fri, 11 Mar 2016 02:18:22 GMT


> On March 10, 2016, 5:14 p.m., Aurora ReviewBot wrote:
> > Master (72bf8db) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > :processJmhResources UP-TO-DATE
> > :jmhClasses
> > :checkstyleJmh
> > :jsHint
> > :checkstyleMain
> > :compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java:38:
Note: Wrote forwarder org.apache.aurora.scheduler.thrift.aop.MockDecoratedThriftForwarder
> > @Forward(AnnotatedAuroraAdmin.class)
> > ^
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java:207:
error: cannot find symbol
> >     configurationManager.validateAndPopulate(ITaskConfig.build(builder));
> >     ^
> >   symbol:   variable configurationManager
> >   location: class ConfigurationManagerTest
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java:217:
error: cannot find symbol
> >     configurationManager.validateAndPopulate(ITaskConfig.build(builder));
> >     ^
> >   symbol:   variable configurationManager
> >   location: class ConfigurationManagerTest
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java:228:
error: cannot find symbol
> >     configurationManager.validateAndPopulate(ITaskConfig.build(builder));
> >     ^
> >   symbol:   variable configurationManager
> >   location: class ConfigurationManagerTest
> > Note: Some input files use or override a deprecated API.
> > Note: Recompile with -Xlint:deprecation for details.
> > 3 errors
> >  FAILED
> > 
> > FAILURE: Build failed with an exception.
> > 
> > * What went wrong:
> > Execution failed for task ':compileTestJava'.
> > > Compilation failed; see the compiler error output for details.
> > 
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
> > 
> > BUILD FAILED
> > 
> > Total time: 2 mins 1.946 secs
> > 
> > 
> > I will refresh this build result if you post a review containing "@ReviewBot retry"

Ah, this is a bad merge.  Rebase incoming.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44685/#review123057
-----------------------------------------------------------


On March 10, 2016, 4:44 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44685/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 4:44 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is currently labeled as experimental.
> 
> Only the most basic wiring is added here, and assumes that the provided image
> includes an ENTRYPOINT.  Unlike Docker support via the thermos executor, this
> approach allows containers with an entrypoint, and does not impose environment
> requirements on the image (e.g. python interpreter, libmesos dependencies).
> 
> Note that when using this, other familiar Aurora facilities that relate to the
> thermos executor will not work.  For example, browsing task logs is not
> supported.
> 
> Support for exercising this from the client will come shortly.
> 
> 
> Diffs
> -----
> 
>   NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb 
>   src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 60746383fccb107ca27925a91aa1803e2cf0fd85

>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java a0d2a717534bbb2e85a556721cc53c1e4b743461

>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 1de6966565d2fbd9abd220ad8162b624b109959a

>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java a34af4d2fb3863ab8197bcdce942c513d629621b

>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
d2789d0eaaeba99fcff3412f1abdd29a09d6514d 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 3db531b52fb2bd94b4b5ce62e6554b5a85ed3ea8

> 
> Diff: https://reviews.apache.org/r/44685/diff/
> 
> 
> Testing
> -------
> 
> Via additional hacking, i successfully ran the stock [hello world](https://hub.docker.com/_/hello-world/)
image.  Within the sandbox, i observed the expected output in the `stdout` file.  Status updates
for the task exiting worked as expected.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message