aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 44532: Allow overriding hostname before announcing
Date Thu, 10 Mar 2016 22:04:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review123011
-----------------------------------------------------------




src/main/python/apache/aurora/executor/bin/thermos_executor_main.py (line 95)
<https://reviews.apache.org/r/44532/#comment185136>

    Specifying the command here feels kind of weird. All other options  we have take the value
directly.


- Stephan Erb


On März 8, 2016, 11:33 nachm., Kunal Thakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> -----------------------------------------------------------
> 
> (Updated März 8, 2016, 11:33 nachm.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Allow overriding hostname before announcing
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py f82858c528808d2a9e77bb56f16e897cfb5bbe73

>   src/main/python/apache/aurora/executor/common/announcer.py 34e36e0a59093468a8934f58bacb68512949347c

> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message