aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Khutornenko <ma...@apache.org>
Subject Re: Review Request 44493: Log and terminate scheduler on updater thread failure.
Date Thu, 10 Mar 2016 20:31:16 GMT


> On March 10, 2016, 3:39 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 128
> > <https://reviews.apache.org/r/44493/diff/1/?file=1290930#file1290930line128>
> >
> >     It looks like the existing usages have inexpensive message formatting, but changing
the util signature to (Lifecycle, Runnable, Logger, String, Object...) may make sense.

I actually prefer the simplicity of the current approach. Also as a bonus having Runnable
as the last parameter improves readability for inline lambdas at call sites.


> On March 10, 2016, 3:39 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 130
> > <https://reviews.apache.org/r/44493/diff/1/?file=1290930#file1290930line130>
> >
> >     It's verbose, but to avoid failure at a distance it probably makes sense to
ensure parameters are non-null before creating the runnable.

Added.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44493/#review122846
-----------------------------------------------------------


On March 8, 2016, 2:21 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44493/
> -----------------------------------------------------------
> 
> (Updated March 8, 2016, 2:21 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Bill Farner.
> 
> 
> Bugs: AURORA-1630
>     https://issues.apache.org/jira/browse/AURORA-1630
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Moved HistoryPruner Runnable handler into AsyncUtil to reuse in updater.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 80dc35ece876d46c8b94540cd6ab19092854867e

>   src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 22753b4579dfdaa1fceea2e095ba7063143959c6

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 48d7e2afb795a743ca9ca3e125a02195e45f1f67

>   src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java c0472d732874dba5cd3534b07301432fed04fcca

>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java b39e38883a0e57210596d5c71ec5c90234837296

> 
> Diff: https://reviews.apache.org/r/44493/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message