aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Khutornenko <ma...@apache.org>
Subject Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support
Date Thu, 10 Mar 2016 19:42:08 GMT


> On March 10, 2016, 6:56 p.m., Joshua Cohen wrote:
> > docs/deploying-aurora-scheduler.md, lines 289-291
> > <https://reviews.apache.org/r/44602/diff/2/?file=1294546#file1294546line289>
> >
> >     I think this "only" is misleading here? If I understand correctly, a task, `devcluster/www-data/prod/hello`
with a dedicated constraint of `*/web.multi` could be scheduled on an agent that has a dedicated
attribute of *either* `*/web.multi` or `www-data/web.multi`, correct?

Not really. Task constraint value must match mesos attribute value exactly. The `*` is used
to remove the role match requirement but does not go as far as having a regex-like meaning
you are suggesting. That would require making `AttributeFilter` syntax sensitive.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122959
-----------------------------------------------------------


On March 10, 2016, 6:44 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 6:44 p.m.)
> 
> 
> Review request for Aurora, Steve Niemitz and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
> 
> 
> Diffs
> -----
> 
>   NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb 
>   docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9 
>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0

>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
d2789d0eaaeba99fcff3412f1abdd29a09d6514d 
> 
> Diff: https://reviews.apache.org/r/44602/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message