aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support
Date Thu, 10 Mar 2016 08:21:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122898
-----------------------------------------------------------




docs/deploying-aurora-scheduler.md (line 286)
<https://reviews.apache.org/r/44602/#comment185004>

    I don't find this sentence very clear. Would probably help to have a more explicit example
instead of speaking of a 'correnspondent attribute'. 
    
    The way this is written right now, it is not 100% clear if I have to put the '*' on the
slave attribute, the job constraint or both.


- Stephan Erb


On March 10, 2016, 1:25 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 1:25 a.m.)
> 
> 
> Review request for Aurora, Steve Niemitz and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
> 
> 
> Diffs
> -----
> 
>   NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb 
>   docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9 
>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0

>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
d2789d0eaaeba99fcff3412f1abdd29a09d6514d 
> 
> Diff: https://reviews.apache.org/r/44602/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message