aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Re: Review Request 44486: Exposing ports to shell health checkers
Date Tue, 08 Mar 2016 02:02:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44486/#review122462
-----------------------------------------------------------



This code lgtm, but adding some docs that define what a shell health checker can expect in
its environment from thermos would be good.  Maybe [here](https://github.com/apache/aurora/blob/master/docs/configuration-reference.md#shellhealthchecker-objects).
 This also seems [NEWS](https://github.com/apache/aurora/blob/master/NEWS) worthy.

- John Sirois


On March 7, 2016, 6:42 p.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44486/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 6:42 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1622
>     https://issues.apache.org/jira/browse/AURORA-1622
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Exposing ports to shell health checkers
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/common/health_check/shell.py 890bf0c5d50d0022c044a37191a2e3145cc6340f

>   src/main/python/apache/aurora/executor/common/health_checker.py 303972778baa04e9d7dd47fb208fe1427e779976

>   src/test/python/apache/aurora/common/health_check/test_shell.py 84f717fbf724c11863b4980fd2740dc23fe1404e

>   src/test/python/apache/aurora/executor/common/test_health_checker.py 9bebce8f5a26662f58075d7ce881a8bdacb2fe46

> 
> Diff: https://reviews.apache.org/r/44486/diff/
> 
> 
> Testing
> -------
> 
> Unit and end to end test.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message