aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kunal Thakar <>
Subject Re: Review Request 42656: Don't destroy session between requests with TRequestsTransport
Date Mon, 07 Mar 2016 19:38:02 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 7, 2016, 7:38 p.m.)

Review request for Aurora and Stephan Erb.


I have added the isOpen() check back to flush as it was breaking unit tests that did not explicitly
call before making client calls. I can fix the unit tests, but I think this
is safer.

On a related note, it looks like this code was copied from THttpClient from the thrift repo
(, where
it made sense to open a new connection with every flush, but in our case, it doesn't make

Repository: aurora


As an API consumer, I want the API client to reuse open connections and not create a new one
for every query.

Diffs (updated)

  src/main/python/apache/aurora/common/ 909021ac203185862267d4359d332fc169a06b7e

  src/test/python/apache/aurora/common/ 1f589a9ae08e1f13be34ad6002ceb11a43fdeb5f



./pants test.pytest src/test/python::


Kunal Thakar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message