Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============0407520878860564002=="
MIME-Version: 1.0
Subject: Re: Review Request 44106: Do not modify list populated by MyBatis
From: Aurora ReviewBot <wfarner@apache.org>
To: Maxim Khutornenko <maxim@apache.org>, Amol Deshmukh <amol@apache.org>
Cc: Aurora <reviews@aurora.apache.org>, Zameer Manji <zmanji@apache.org>,
 Aurora ReviewBot <wfarner@apache.org>
Date: Fri, 26 Feb 2016 23:04:04 -0000
Message-ID: <20160226230404.1671.80570@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Aurora ReviewBot <noreply@reviews.apache.org>
References: <20160226230048.28813.56391@reviews.apache.org>
In-Reply-To: <20160226230048.28813.56391@reviews.apache.org>
Reply-To: Aurora ReviewBot <wfarner@apache.org>

--===============0407520878860564002==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44106/#review120992
-----------------------------------------------------------


Master (7e32c43) is red with this patch.
  ./build-support/jenkins/build.sh

+ date
Fri Feb 26 23:02:23 UTC 2016
+ ./gradlew -Pq clean build
:buildSrc:clean UP-TO-DATE
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'aurora'.
> Could not open proj class cache for build file '/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' (/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/proj).
   > Timeout waiting to lock proj class cache for build file '/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' (/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/proj). It is currently in use by another Gradle instance.
     Owner PID: unknown
     Our PID: 5351
     Owner Operation: unknown
     Our operation: Initialize cache
     Lock file: /home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/proj/cache.properties.lock

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 1 mins 38.989 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 26, 2016, 11 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44106/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 11 p.m.)
> 
> 
> Review request for Aurora, Amol Deshmukh and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1625
>     https://issues.apache.org/jira/browse/AURORA-1625
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> A ConcurrentModificationException can occur when multiple threads are sorting the same task event list. This is possible because we have enabled MyBatis caching with the readOnly flag which can use the same instance to populate different `DbScheduledTask` instances.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbScheduledTask.java 8d0dab0fa995416b462a75a33d5003aa54272854 
>   src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java dc5e2bd142676e837b390e4268148831b3669941 
> 
> Diff: https://reviews.apache.org/r/44106/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew test
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


--===============0407520878860564002==--