Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============0223038695805966558=="
MIME-Version: 1.0
Subject: Re: Review Request 43622: Updating scheduler backup restore
 instructions.
From: Stephan Erb <serb@apache.org>
To: John Sirois <jsirois@apache.org>
Cc: Aurora <reviews@aurora.apache.org>, Maxim Khutornenko <maxim@apache.org>
Date: Tue, 23 Feb 2016 16:44:36 -0000
Message-ID: <20160223164436.23847.49204@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Stephan Erb <noreply@reviews.apache.org>
References: <20160216231046.13179.40820@reviews.apache.org>
In-Reply-To: <20160216231046.13179.40820@reviews.apache.org>
Reply-To: Stephan Erb <serb@apache.org>

--===============0223038695805966558==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/#review120329
-----------------------------------------------------------


Fix it, then Ship it!


We've tested this on a cluster with three masters. Worked great! Couple of minor additions and corrections below.


docs/storage-config.md (line 93)
<https://reviews.apache.org/r/43622/#comment181762>

    I'd propose to move this section after the point "Identify the leading scheduler". Only at that point it is clear what what scheduler URL to put there.
    
    Slight nitpick: the sentence is difficult to read due to the duplicate `aurora_admin`. One of those can be dropped.


docs/storage-config.md (line 95)
<https://reviews.apache.org/r/43622/#comment181763>

    There is a small bug in the referenced documentation snippet. The `scheduler_url` must contain the schema (`http://`) otherwise `aurora_admin scheduler_stage_recovery` won't work.


docs/storage-config.md (line 97)
<https://reviews.apache.org/r/43622/#comment181764>

    Addition regarding my first statement: This sub-section probably does not need to be moved. In can be kept in the preperation section.


docs/storage-config.md (line 115)
<https://reviews.apache.org/r/43622/#comment181765>

    I think we might leave thos one out. Does not seem necessary.


docs/storage-config.md (line 137)
<https://reviews.apache.org/r/43622/#comment181767>

    Two important points are missing here:
    
    * has to be copied into the db backup folder
    * the `scheduler-backup...` is the file name and not a path


- Stephan Erb


On Feb. 17, 2016, 12:10 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43622/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2016, 12:10 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Stephan Erb.
> 
> 
> Bugs: AURORA-1605
>     https://issues.apache.org/jira/browse/AURORA-1605
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Updating scheduler backup restore instructions.
> 
> 
> Diffs
> -----
> 
>   docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
>   docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 
> 
> Diff: https://reviews.apache.org/r/43622/diff/
> 
> 
> Testing
> -------
> 
> https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


--===============0223038695805966558==--