Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 123E918191 for ; Thu, 11 Feb 2016 23:03:07 +0000 (UTC) Received: (qmail 66308 invoked by uid 500); 11 Feb 2016 23:03:01 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 66254 invoked by uid 500); 11 Feb 2016 23:03:01 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 66229 invoked by uid 99); 11 Feb 2016 23:03:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Feb 2016 23:03:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 808252A60A3; Thu, 11 Feb 2016 23:03:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1049268525633124951==" MIME-Version: 1.0 Subject: Review Request 43503: Making OfferManager.getOffers() return a new set rather than a view From: Maxim Khutornenko To: Bill Farner , Zameer Manji Cc: Aurora , Maxim Khutornenko Date: Thu, 11 Feb 2016 23:03:00 -0000 Message-ID: <20160211230300.24149.57228@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Maxim Khutornenko X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43503/ X-Sender: Maxim Khutornenko Reply-To: Maxim Khutornenko X-ReviewRequest-Repository: aurora --===============1049268525633124951== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43503/ ----------------------------------------------------------- Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora Description ------- Benchmark testing, as expected, did not show any meaningful changes in performance: Before: ``` Benchmark (numPendingTasks) Mode Cnt Score Error Units SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 60.414 ± 1.630 ops/s ``` After: ``` Benchmark (numPendingTasks) Mode Cnt Score Error Units SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 61.167 ± 1.169 ops/s ``` Diffs ----- src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 394d25f8a496ee24505387e5767acf458cb3f5f4 Diff: https://reviews.apache.org/r/43503/diff/ Testing ------- Thanks, Maxim Khutornenko --===============1049268525633124951==--