Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C37E71837A for ; Thu, 11 Feb 2016 00:27:21 +0000 (UTC) Received: (qmail 1494 invoked by uid 500); 11 Feb 2016 00:27:21 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 1444 invoked by uid 500); 11 Feb 2016 00:27:21 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 1416 invoked by uid 99); 11 Feb 2016 00:27:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Feb 2016 00:27:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4172E29B6DE; Thu, 11 Feb 2016 00:27:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1935504621203306568==" MIME-Version: 1.0 Subject: Re: Review Request 43457: Increase throughput of DbTaskStore From: Bill Farner To: Bill Farner , Maxim Khutornenko Cc: Aurora , Zameer Manji Date: Thu, 11 Feb 2016 00:27:20 -0000 Message-ID: <20160211002720.24150.51333@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Bill Farner X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43457/ X-Sender: Bill Farner References: <20160211001520.24150.15628@reviews.apache.org> In-Reply-To: <20160211001520.24150.15628@reviews.apache.org> X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssginedPort.java Reply-To: Bill Farner X-ReviewRequest-Repository: aurora --===============1935504621203306568== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43457/#review118775 ----------------------------------------------------------- Please substitute Maxim for me on this review. - Bill Farner On Feb. 10, 2016, 4:15 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43457/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 4:15 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Profiling master indicated that the bottleneck was MyBatis populating ResultSets and populating the resulting objects. This patch removes subselects, which reduces the number of ResultSets and removes the population of an object via a constructor which is slower than populating an object via setters. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssginedPort.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java 93722395ed9fcd22dcb12e34e648e6e410952d43 > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbScheduledTask.java 502a1fa6fc141df498f0f09af292ce24e269731d > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml b1394cf44b7ddafcbc47bb1968306d0b33293380 > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml ea469cce31544221c34ae05a1c65f71271985655 > > Diff: https://reviews.apache.org/r/43457/diff/ > > > Testing > ------- > > Master: > Benchmark (numTasks) Mode Cnt Score Error Units > TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10000 thrpt 5 44.052 ± 14.689 ops/s > TaskStoreBenchmarks.DBFetchTasksBenchmark.run 50000 thrpt 5 0.179 ± 0.052 ops/s > TaskStoreBenchmarks.DBFetchTasksBenchmark.run 100000 thrpt 5 0.087 ± 0.022 ops/s > > This Patch: > Benchmark (numTasks) Mode Cnt Score Error Units > TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10000 thrpt 5 51.531 ± 7.236 ops/s > TaskStoreBenchmarks.DBFetchTasksBenchmark.run 50000 thrpt 5 7.370 ± 1.320 ops/s > TaskStoreBenchmarks.DBFetchTasksBenchmark.run 100000 thrpt 5 2.143 ± 1.234 ops/s > > > Thanks, > > Zameer Manji > > --===============1935504621203306568==--