Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2134518AC3 for ; Fri, 5 Feb 2016 21:20:20 +0000 (UTC) Received: (qmail 40911 invoked by uid 500); 5 Feb 2016 21:20:20 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 40855 invoked by uid 500); 5 Feb 2016 21:20:20 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 40816 invoked by uid 99); 5 Feb 2016 21:20:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Feb 2016 21:20:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5256029A786; Fri, 5 Feb 2016 21:20:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6994211330047886010==" MIME-Version: 1.0 Subject: Re: Review Request 43262: Backfilling JobConfiguration.Identity From: Bill Farner To: Bill Farner , John Sirois Cc: Aurora , Maxim Khutornenko Date: Fri, 05 Feb 2016 21:20:19 -0000 Message-ID: <20160205212019.1669.36122@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Bill Farner X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43262/ X-Sender: Bill Farner References: <20160205210852.7684.89738@reviews.apache.org> In-Reply-To: <20160205210852.7684.89738@reviews.apache.org> Reply-To: Bill Farner X-ReviewRequest-Repository: aurora --===============6994211330047886010== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Feb. 5, 2016, 1:08 p.m., John Sirois wrote: > > Can you note the technique you used for finding all last vestigaes of missing backfill in the testing done? > > Was this grep-provable as the last bit to fix for example? > > Maxim Khutornenko wrote: > That was mostly an oversight as we should have backfilled everything touched in api.thrift: https://reviews.apache.org/r/42811/diff/3#1 John - do you think this is something we should consider tackling with codegen? For example, if we could make the `IIdentity` and `ITaskConfig` code do this it seems like we wouldn't be playing whack-a-mole. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43262/#review118076 ----------------------------------------------------------- On Feb. 5, 2016, 1:03 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43262/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 1:03 p.m.) > > > Review request for Aurora, John Sirois and Bill Farner. > > > Bugs: AURORA-1610 > https://issues.apache.org/jira/browse/AURORA-1610 > > > Repository: aurora > > > Description > ------- > > Backfilling JobConfiguration.Identity > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/log/ThriftBackfill.java 9c88f5763d77ec0a304fdb2530ef6b6c1b0f230e > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 13fcf9fd3afc14cf572d4bc7de355ff698b2c222 > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 3b176db12369bc5a2a63cb0018ffca7ef8b9055d > src/test/java/org/apache/aurora/scheduler/storage/log/ThriftBackfillTest.java 506d5919b9db14e04b10190a5f2d2aef123ac1dc > > Diff: https://reviews.apache.org/r/43262/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > > --===============6994211330047886010==--