Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C6716184CA for ; Fri, 5 Feb 2016 02:14:04 +0000 (UTC) Received: (qmail 33701 invoked by uid 500); 5 Feb 2016 02:14:04 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 33650 invoked by uid 500); 5 Feb 2016 02:14:04 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 33622 invoked by uid 99); 5 Feb 2016 02:14:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Feb 2016 02:14:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DAEB029A48A; Fri, 5 Feb 2016 02:14:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8346125801035978764==" MIME-Version: 1.0 Subject: Re: Review Request 43237: Add benchmark for feching tasks. From: Aurora ReviewBot To: Bill Farner , Maxim Khutornenko Cc: Aurora ReviewBot , Zameer Manji , Aurora Date: Fri, 05 Feb 2016 02:14:03 -0000 Message-ID: <20160205021403.1669.25323@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43237/ X-Sender: Aurora ReviewBot References: <20160205020442.1670.26137@reviews.apache.org> In-Reply-To: <20160205020442.1670.26137@reviews.apache.org> X-ReviewBoard-Diff-For: src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora --===============8346125801035978764== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43237/#review117940 ----------------------------------------------------------- Master (505f310) is red with this patch. ./build-support/jenkins/build.sh Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2 Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor :generateBuildProperties :processResources :classes :jar :startScripts :distTar :distZip :assemble :compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API. Note: Recompile with -Xlint:deprecation for details. :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:1: error: Line does not match expected header line of '^\/\*\*$'. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:45:12: error: 'public' modifier out of order with the JLS suggestions. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:47:14: error: 'public' modifier out of order with the JLS suggestions. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:52:34: error: 'numTasks' hides a field. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:72: error: 'member def type' have incorrect indentation level 5, expected level should be 6. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:72: error: 'method def' child have incorrect indentation level 5, expected level should be 6. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:75: error: 'method def modifier' have incorrect indentation level 12, expected level should be one of the following: 9, 11, 13. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:77: error: 'method def' child have incorrect indentation level 14, expected level should be one of the following: 11, 13, 15. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:78: error: 'method def rcurly' have incorrect indentation level 12, expected level should be one of the following: 9, 11, 13. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:79: error: 'object def rcurly' have incorrect indentation level 10, expected level should be one of the following: 7, 9, 11. FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':checkstyleJmh'. > Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/jmh.html * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 2 mins 12.026 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Feb. 5, 2016, 2:04 a.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43237/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 2:04 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Repository: aurora > > > Description > ------- > > This adds a benchmark for the throughput of fetching tasks from both the DB and InMem store. > > > Diffs > ----- > > src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java PRE-CREATION > > Diff: https://reviews.apache.org/r/43237/diff/ > > > Testing > ------- > > ./gradlew jmh -Pbenchmarks='TaskStoreBenchmarks.*' > > TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10000 thrpt 5 44.395 ± 15.378 ops/s > TaskStoreBenchmarks.DBFetchTasksBenchmark.run 50000 thrpt 5 0.184 ± 0.013 ops/s > TaskStoreBenchmarks.DBFetchTasksBenchmark.run 100000 thrpt 5 0.077 ± 0.037 ops/s > TaskStoreBenchmarks.MemFetchTasksBenchmark.run 10000 thrpt 5 562.370 ± 768.131 ops/s > TaskStoreBenchmarks.MemFetchTasksBenchmark.run 50000 thrpt 5 81.901 ± 28.108 ops/s > TaskStoreBenchmarks.MemFetchTasksBenchmark.run 100000 thrpt 5 38.883 ± 14.443 ops/s > > > Thanks, > > Zameer Manji > > --===============8346125801035978764==--