Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 37B8A18693 for ; Tue, 2 Feb 2016 03:12:08 +0000 (UTC) Received: (qmail 27459 invoked by uid 500); 2 Feb 2016 03:09:30 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 24028 invoked by uid 500); 2 Feb 2016 03:09:23 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 21335 invoked by uid 99); 2 Feb 2016 03:04:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Feb 2016 03:04:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5EA9628A26C; Tue, 2 Feb 2016 03:04:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0675265056694762785==" MIME-Version: 1.0 Subject: Re: Review Request 43027: Optionally enable setuid inside Docker containers From: Aurora ReviewBot To: Aurora , Benjamin Staffin , Aurora ReviewBot Date: Tue, 02 Feb 2016 03:04:04 -0000 Message-ID: <20160202030404.30946.35155@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43027/ X-Sender: Aurora ReviewBot References: <20160202024935.30946.91317@reviews.apache.org> In-Reply-To: <20160202024935.30946.91317@reviews.apache.org> Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora --===============0675265056694762785== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/#review117348 ----------------------------------------------------------- Master (824e396) is red with this patch. ./build-support/jenkins/build.sh  def test_checkpoint_path(self):  mock_runner_provider = create_autospec(spec=DefaultThermosTaskRunnerProvider)  mock_dump_runner_pex = create_autospec(spec=dump_runner_pex)  mock_dump_runner_pex.return_value = Mock()  mock_options = Mock()  mock_options.execute_as_user = False  mock_options.nosetuid = False  with patch(  'apache.aurora.executor.bin.thermos_executor_main.dump_runner_pex',  return_value=mock_dump_runner_pex):  with patch(  'apache.aurora.executor.bin.thermos_executor_main.DefaultThermosTaskRunnerProvider',  return_value=mock_runner_provider) as mock_provider:    expected_path = os.path.join(os.path.abspath('.'), MesosPathDetector.DEFAULT_SANDBOX_PATH) > thermos_executor = initialize(mock_options) src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py:44: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ .pants.d/python-setup/chroots/68e800ae7d5d1db64fe3e98999fa622f29c93f29/apache/aurora/executor/bin/thermos_executor_main.py:204: in initialize  setuid = parse_setuid_opt(options.setuid) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ value =  def parse_setuid_opt(value):  """Post-process --setuid options"""  opts = value.split(',', 1) > if opts[0] == 'off': E TypeError: 'Mock' object does not support indexing .pants.d/python-setup/chroots/68e800ae7d5d1db64fe3e98999fa622f29c93f29/apache/aurora/executor/bin/thermos_executor_main.py:169: TypeError generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.executor.bin.bin.xml ======= 1 failed, 1 passed in 0.76 seconds ======= FAILURE 03:04:03 05:45 [complete] FAILURE I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Feb. 2, 2016, 2:49 a.m., Benjamin Staffin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43027/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2016, 2:49 a.m.) > > > Review request for Aurora. > > > Bugs: AURORA-1237 > https://issues.apache.org/jira/browse/AURORA-1237 > > > Repository: aurora > > > Description > ------- > > Adds a flag to enable the new behavior. If enabled, also sets > ownership of the sandbox directory appropriately. > > > Diffs > ----- > > NEWS ef1e75f7ec467ef3a5a33c6dee5b6ef5743c11f7 > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py f4f5cd77b6444c225ec960c7e2cf5349a80bd344 > src/main/python/apache/aurora/executor/common/sandbox.py 4780232318ffdf8c6bbbe78bee518886cffd580a > src/main/python/apache/aurora/executor/thermos_task_runner.py 3896e3841562600379705dbf78a6f62728246348 > > Diff: https://reviews.apache.org/r/43027/diff/ > > > Testing > ------- > > TBD > > > Thanks, > > Benjamin Staffin > > --===============0675265056694762785==--