Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ED08C183E7 for ; Tue, 2 Feb 2016 01:55:32 +0000 (UTC) Received: (qmail 92696 invoked by uid 500); 2 Feb 2016 01:55:32 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 92634 invoked by uid 500); 2 Feb 2016 01:55:32 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 92613 invoked by uid 99); 2 Feb 2016 01:55:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Feb 2016 01:55:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 84E4F28A24C; Tue, 2 Feb 2016 01:55:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2793678188308573342==" MIME-Version: 1.0 Subject: Re: Review Request 43080: Fixing duplicate instances in the UI. From: Bill Farner To: Bill Farner Cc: Aurora , Maxim Khutornenko Date: Tue, 02 Feb 2016 01:55:31 -0000 Message-ID: <20160202015531.30947.89283@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Bill Farner X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43080/ X-Sender: Bill Farner X-ReviewBoard-ShipIt: 1 References: <20160202013746.30947.31934@reviews.apache.org> In-Reply-To: <20160202013746.30947.31934@reviews.apache.org> Reply-To: Bill Farner X-ReviewRequest-Repository: aurora --===============2793678188308573342== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43080/#review117338 ----------------------------------------------------------- Ship it! Thanks! - Bill Farner On Feb. 1, 2016, 5:37 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43080/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 5:37 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1604 > https://issues.apache.org/jira/browse/AURORA-1604 > > > Repository: aurora > > > Description > ------- > > Also, dropped TaskQuery.owner field as all supporting filtering logic for it is long gone. > > > Diffs > ----- > > NEWS ef1e75f7ec467ef3a5a33c6dee5b6ef5743c11f7 > api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0 > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java ae05cd4b2f39b9c0450d77ebd16a18664c310ecb > src/main/resources/scheduler/assets/js/services.js 1a76a3f1149c69e7a8f34261df2d955ae240eb6c > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2b0451b77bb82f58200b6048c8540bcc76f76b14 > > Diff: https://reviews.apache.org/r/43080/diff/ > > > Testing > ------- > > e2e tests and manual testing in vagrant > > > Thanks, > > Maxim Khutornenko > > --===============2793678188308573342==--