Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3A9781834C for ; Mon, 1 Feb 2016 20:38:13 +0000 (UTC) Received: (qmail 51699 invoked by uid 500); 1 Feb 2016 20:38:07 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 51649 invoked by uid 500); 1 Feb 2016 20:38:07 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 51621 invoked by uid 99); 1 Feb 2016 20:38:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Feb 2016 20:38:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 94F4028A13A; Mon, 1 Feb 2016 20:38:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1485434804943525341==" MIME-Version: 1.0 Subject: Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter. From: Bill Farner To: Bill Farner , Zameer Manji Cc: Joshua Cohen , Aurora Date: Mon, 01 Feb 2016 20:38:05 -0000 Message-ID: <20160201203805.30947.75277@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Bill Farner X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42964/ X-Sender: Bill Farner References: <20160201200557.30946.93868@reviews.apache.org> In-Reply-To: <20160201200557.30946.93868@reviews.apache.org> Reply-To: Bill Farner X-ReviewRequest-Repository: aurora --===============1485434804943525341== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117259 ----------------------------------------------------------- src/main/python/apache/aurora/client/api/scheduler_client.py (line 56) Strings don't match - all the more reason this demands: a.) a constant, likely in api.thrift b.) an end-to-end test (you could turn off ZK and make sure you can still send a simple API request to the scheduler) - Bill Farner On Feb. 1, 2016, 12:05 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42964/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 12:05 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1601 > https://issues.apache.org/jira/browse/AURORA-1601 > > > Repository: aurora > > > Description > ------- > > Add header to allow bypassing the LeaderRedirectFilter. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3 > src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af > src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d > src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e > src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59 > src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614 > src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d > > Diff: https://reviews.apache.org/r/42964/diff/ > > > Testing > ------- > > ./gradlew build -Pq > > > Thanks, > > Joshua Cohen > > --===============1485434804943525341==--