aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 44106: Do not modify list populated by MyBatis
Date Fri, 26 Feb 2016 23:36:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44106/
-----------------------------------------------------------

(Updated Feb. 26, 2016, 3:36 p.m.)


Review request for Aurora, Amol Deshmukh and Maxim Khutornenko.


Changes
-------

Style Fixes


Bugs: AURORA-1625
    https://issues.apache.org/jira/browse/AURORA-1625


Repository: aurora


Description
-------

A ConcurrentModificationException can occur when multiple threads are sorting the same task
event list. This is possible because we have enabled MyBatis caching with the readOnly flag
which can use the same instance to populate different `DbScheduledTask` instances.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/storage/db/views/DbScheduledTask.java 8d0dab0fa995416b462a75a33d5003aa54272854

  src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java dc5e2bd142676e837b390e4268148831b3669941


Diff: https://reviews.apache.org/r/44106/diff/


Testing
-------

./gradlew test


Thanks,

Zameer Manji


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message