aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Review Request 43567: Always close Deflater/Inflater streams
Date Sun, 14 Feb 2016 20:35:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43567/
-----------------------------------------------------------

Review request for Aurora, John Sirois and Zameer Manji.


Repository: aurora


Description
-------

Closing Deflater/Inflater streams explicitly frees their native memory instantly. Otherwise,
the memory will only be freed once the object finalizer runs.

I got the idea from this article http://www.evanjones.ca/java-native-leak-bug.html. Unfortunately,
we cannot use the Java close-with-resource feature, as `TTransport` in our current Thrift
version does not implement `Closable`.


Diffs
-----

  src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 6b65c0f6cb60b98ff352c4c5d5fed38d52b4b062


Diff: https://reviews.apache.org/r/43567/diff/


Testing
-------

./gradlew -Pq build


Thanks,

Stephan Erb


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message