aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Re: Review Request 43534: Explain observer `--mesos-root` configuration.
Date Fri, 12 Feb 2016 19:36:19 GMT


> On Feb. 12, 2016, 12:11 p.m., Stephan Erb wrote:
> > docs/installing.md, line 239
> > <https://reviews.apache.org/r/43534/diff/3/?file=1240884#file1240884line239>
> >
> >     I fear that the listed options here might easily become outdated without us
noticing.
> 
> John Sirois wrote:
>     Can you suggest a replacement for this output then?
>     My focus is only on the `--mesos-root` `[default...` output, but I have no facility
to bold those lines.

I think a simple eliding of the extraneous output here is an improvement, see what you think.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43534/#review119063
-----------------------------------------------------------


On Feb. 12, 2016, 11:44 a.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43534/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2016, 11:44 a.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1617
>     https://issues.apache.org/jira/browse/AURORA-1617
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This adds a note about configuration of the observer's `--mesos-root` to
> match the Mesos master `--work_dir` for proper observer functioning.
> 
>  docs/installing.md | 33 ++++++++++++++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -----
> 
>   docs/installing.md 1620a6fc3ebe428e0269f7edd0377d53ded2c796 
> 
> Diff: https://reviews.apache.org/r/43534/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1617/docs/installing.md#configuration-1
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message