aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Khutornenko <ma...@apache.org>
Subject Review Request 43503: Making OfferManager.getOffers() return a new set rather than a view
Date Thu, 11 Feb 2016 23:03:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43503/
-----------------------------------------------------------

Review request for Aurora, Bill Farner and Zameer Manji.


Repository: aurora


Description
-------

Benchmark testing, as expected, did not show any meaningful changes in performance:
Before:
```
Benchmark                                                       (numPendingTasks)   Mode 
Cnt   Score   Error  Units
SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                  1  thrpt 
 10  60.414 ± 1.630  ops/s
```
After:
```
Benchmark                                                       (numPendingTasks)   Mode 
Cnt   Score   Error  Units
SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                  1  thrpt 
 10  61.167 ± 1.169  ops/s
```


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 394d25f8a496ee24505387e5767acf458cb3f5f4


Diff: https://reviews.apache.org/r/43503/diff/


Testing
-------


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message