aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Re: Review Request 43373: Implementing 'aurora job add' command.
Date Wed, 10 Feb 2016 18:25:05 GMT


> On Feb. 10, 2016, 8:57 a.m., John Sirois wrote:
> > src/main/python/apache/aurora/client/cli/context.py, line 195
> > <https://reviews.apache.org/r/43373/diff/2/?file=1238868#file1238868line195>
> >
> >     This is a lie as is the method name, this returns a set of int and not a list
of ScheduledTask.  Definitely update the doc but possibly also the method name to `get_active_instance_ids_or_raise`.
> 
> Maxim Khutornenko wrote:
>     It's not actualy a lie. We use `instances` in many other places in client (e.g. jobs.py,
options.py, JobMonitor etc.) with the meaning of `instance_ids`. We use `tasks` when we mean
`ScheduledTask`. I prefer to keep this convention as more concise.

Ok, but the "Same as ..." is a lie.  The get_active_instances returns ScheduledTask, this
returns int, so that bit of language could stand correction.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43373/#review118665
-----------------------------------------------------------


On Feb. 10, 2016, 11:20 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43373/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 11:20 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Bill Farner.
> 
> 
> Bugs: AURORA-1258
>     https://issues.apache.org/jira/browse/AURORA-1258
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Taking advantage of the refactored addInstances RPC to add a 'scale out' client command.
> 
> The mitigation of .aurora config file `instances` value mismatch is currently discussed
at http://markmail.org/message/5ekpapmxr4vxxcd5 and will be addressed separately.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/__init__.py 63bd649377816c72ef2453d9abb7363637a91680

>   src/main/python/apache/aurora/client/cli/context.py 24a37ec60a8845b4816d292c49fed814ba0a5854

>   src/main/python/apache/aurora/client/cli/jobs.py 67ab4f01eca911aea041328410c6104b63ff8344

>   src/main/python/apache/aurora/client/cli/options.py 226397865e54cf4c0a59ecb91b93ddc10967edf7

>   src/main/python/apache/aurora/client/hooks/hooked_api.py 185e57d08aa13b687529fefd7c356f3d50c6af33

>   src/test/python/apache/aurora/api_util.py 9d44b884e5e67506acaaecda1d9ff02a80cf1567

>   src/test/python/apache/aurora/client/api/test_api.py 974fc7e5a8ea13020e2c01a2088a8535947f05bc

>   src/test/python/apache/aurora/client/cli/test_add.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_options.py 21d5888c0a87e07a385159de0b56420086666d9d

>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py 67517a23535e3f535c3114193a5ae06bf4326515

>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py f4b771bc968143845772a0149a943c97c5aaf963

> 
> Diff: https://reviews.apache.org/r/43373/diff/
> 
> 
> Testing
> -------
> 
> local and manual tests in vagrant
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message