aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <wfar...@apache.org>
Subject Re: Review Request 43397: Reject NULL for enum values in H2.
Date Wed, 10 Feb 2016 01:15:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43397/#review118529
-----------------------------------------------------------


Ship it!




Ship It!

- Bill Farner


On Feb. 9, 2016, 4:57 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43397/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 4:57 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> While I was working on something else, I introduced an error where MyBatis was populating
a thrift enum value and was reading in NULL. I realized that the code would currently treat
this as enum value 0 and mask the error. This patch modifies the schema and TEnum type handler
to reject populating a thrift enum value from NULL.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/AbstractTEnumTypeHandler.java
892af5ddfa973148d7ae778af83c1357a23aef6a 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 7fbdcbf50fca7e974e56ed27a91ec682c6c8c3c2

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 3ce78e355368acb539cd374638be665535bbfd4a

> 
> Diff: https://reviews.apache.org/r/43397/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> e2e tests
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message