aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Khutornenko <ma...@apache.org>
Subject Re: Review Request 43373: Implementing 'aurora job add' command.
Date Tue, 09 Feb 2016 22:04:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43373/
-----------------------------------------------------------

(Updated Feb. 9, 2016, 10:04 p.m.)


Review request for Aurora, John Sirois and Bill Farner.


Changes
-------

CR feedback.


Bugs: AURORA-1258
    https://issues.apache.org/jira/browse/AURORA-1258


Repository: aurora


Description
-------

Taking advantage of the refactored addInstances RPC to add a 'scale out' client command.

The mitigation of .aurora config file `instances` value mismatch is currently discussed at
http://markmail.org/message/5ekpapmxr4vxxcd5 and will be addressed separately.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/api/__init__.py 63bd649377816c72ef2453d9abb7363637a91680

  src/main/python/apache/aurora/client/cli/context.py 24a37ec60a8845b4816d292c49fed814ba0a5854

  src/main/python/apache/aurora/client/cli/jobs.py deba3a9026384e5bd436e611ab5b5ae3afc1cfcc

  src/main/python/apache/aurora/client/cli/options.py 226397865e54cf4c0a59ecb91b93ddc10967edf7

  src/main/python/apache/aurora/client/hooks/hooked_api.py 185e57d08aa13b687529fefd7c356f3d50c6af33

  src/test/python/apache/aurora/api_util.py 9d44b884e5e67506acaaecda1d9ff02a80cf1567 
  src/test/python/apache/aurora/client/api/test_api.py 1f041f42fcd5ee5d147afacd9c8f83aa3129fe47

  src/test/python/apache/aurora/client/cli/test_add.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/test_options.py 21d5888c0a87e07a385159de0b56420086666d9d

  src/test/python/apache/aurora/client/hooks/test_hooked_api.py 67517a23535e3f535c3114193a5ae06bf4326515

  src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py f4b771bc968143845772a0149a943c97c5aaf963


Diff: https://reviews.apache.org/r/43373/diff/


Testing
-------

local and manual tests in vagrant


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message