aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 42727: Remove the --announcer-enable executor flag.
Date Tue, 02 Feb 2016 22:07:57 GMT


> On Feb. 2, 2016, 9:31 p.m., Zhitao Li wrote:
> > Sorry for coming to this only after it's committed, but I think this might create
trouble for operators during upgrade.
> > 
> > Because the new executor will not understand the `--announce-enable` flag and crashes,
the operator has to coordinate disabling the flag from scheduler side first, and push executor.
Also, during this window between scheduler upgrade and cluster-wise executor upgrade, announce
might be broken.
> > 
> > Can I suggest to make this flag optional and no-op for the deprecation cycle (max
of one version or 90 days according to recent email conversations), then remove this afterwards?
> 
> Bill Farner wrote:
>     You could work around this with a script that wraps the executor, but that would
be overly-complicated.  Your suggestion sounds spot on.  I'm not available at the moment to
put together the patch, but i can review/ship!

https://reviews.apache.org/r/43112/ includes a quick patch.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42727/#review117482
-----------------------------------------------------------


On Jan. 26, 2016, 6:40 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42727/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 6:40 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove the --announcer-enable executor flag.
> 
> 
> Diffs
> -----
> 
>   NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 57fa312ca6c007731fd88ace1bea507320d14700

>   examples/vagrant/upstart/aurora-scheduler.conf 69025dd85011751b1036615af9944a4f7693bb15

>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 6214882cd60211b18fa4ce6f43442184b2dccac8

>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 12726936ee85d2ee3dba19eb497873d7422886e6

>   src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-thermos-executor.json
8d4d90b18451d8a2cc7cbe2d25f64942d0045491 
> 
> Diff: https://reviews.apache.org/r/42727/diff/
> 
> 
> Testing
> -------
> 
> Running tests now.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message