aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <wfar...@apache.org>
Subject Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.
Date Tue, 02 Feb 2016 21:57:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117491
-----------------------------------------------------------


Ship it!




Thanks for adding the test coverage!

- Bill Farner


On Feb. 2, 2016, 1:51 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 1:51 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1601
>     https://issues.apache.org/jira/browse/AURORA-1601
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add header to allow bypassing the LeaderRedirectFilter.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0

>   examples/vagrant/clusters_direct.json PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3

>   src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af

>   src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d

>   src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e

>   src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59

>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d

>   src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh PRE-CREATION

>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1171dca4af01a11e684f0b7a63a50250a8da1d22

> 
> Diff: https://reviews.apache.org/r/42964/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message