aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 43027: Optionally enable setuid inside Docker containers
Date Tue, 02 Feb 2016 03:04:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43027/#review117348
-----------------------------------------------------------



Master (824e396) is red with this patch.
  ./build-support/jenkins/build.sh

                         def test_checkpoint_path(self):
                           mock_runner_provider = create_autospec(spec=DefaultThermosTaskRunnerProvider)
                           mock_dump_runner_pex = create_autospec(spec=dump_runner_pex)
                           mock_dump_runner_pex.return_value = Mock()
                           mock_options = Mock()
                           mock_options.execute_as_user = False
                           mock_options.nosetuid = False
                           with patch(
                               'apache.aurora.executor.bin.thermos_executor_main.dump_runner_pex',
                               return_value=mock_dump_runner_pex):
                             with patch(
                                 'apache.aurora.executor.bin.thermos_executor_main.DefaultThermosTaskRunnerProvider',
                                 return_value=mock_runner_provider) as mock_provider:
                         
                               expected_path = os.path.join(os.path.abspath('.'), MesosPathDetector.DEFAULT_SANDBOX_PATH)
                     >         thermos_executor = initialize(mock_options)
                     
                     src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py:44:

                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     .pants.d/python-setup/chroots/68e800ae7d5d1db64fe3e98999fa622f29c93f29/apache/aurora/executor/bin/thermos_executor_main.py:204:
in initialize
                         setuid = parse_setuid_opt(options.setuid)
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     value = <Mock name='mock.setuid' id='140485959309968'>
                     
                         def parse_setuid_opt(value):
                           """Post-process --setuid options"""
                           opts = value.split(',', 1)
                     >     if opts[0] == 'off':
                     E     TypeError: 'Mock' object does not support indexing
                     
                     .pants.d/python-setup/chroots/68e800ae7d5d1db64fe3e98999fa622f29c93f29/apache/aurora/executor/bin/thermos_executor_main.py:169:
TypeError
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.executor.bin.bin.xml

                     ======= 1 failed, 1 passed in 0.76 seconds =======
                     
FAILURE


03:04:03 05:45   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 2, 2016, 2:49 a.m., Benjamin Staffin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43027/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 2:49 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-1237
>     https://issues.apache.org/jira/browse/AURORA-1237
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adds a flag to enable the new behavior.  If enabled, also sets
> ownership of the sandbox directory appropriately.
> 
> 
> Diffs
> -----
> 
>   NEWS ef1e75f7ec467ef3a5a33c6dee5b6ef5743c11f7 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py f4f5cd77b6444c225ec960c7e2cf5349a80bd344

>   src/main/python/apache/aurora/executor/common/sandbox.py 4780232318ffdf8c6bbbe78bee518886cffd580a

>   src/main/python/apache/aurora/executor/thermos_task_runner.py 3896e3841562600379705dbf78a6f62728246348

> 
> Diff: https://reviews.apache.org/r/43027/diff/
> 
> 
> Testing
> -------
> 
> TBD
> 
> 
> Thanks,
> 
> Benjamin Staffin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message