Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============1097203624445072127=="
MIME-Version: 1.0
Subject: Re: Review Request 42975: Change the way arguments are passed to
 scheduler in debian
From: Dmitriy Shirchenko <caldima@gmail.com>
To: Bill Farner <wfarner@apache.org>, Dmitriy Shirchenko <caldima@gmail.com>,
 John Sirois <jsirois@apache.org>
Cc: Aurora <reviews@aurora.apache.org>, Kunal Thakar <kunalt@gmail.com>
Date: Fri, 29 Jan 2016 20:37:31 -0000
Message-ID: <20160129203731.12172.68513@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Dmitriy Shirchenko <noreply@reviews.apache.org>
In-Reply-To: <20160129201726.25059.8491@reviews.apache.org>
References: <20160129201726.25059.8491@reviews.apache.org>
Reply-To: Dmitriy Shirchenko <caldima@gmail.com>

--===============1097203624445072127==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42975/#review117007
-----------------------------------------------------------


Ship it!


Ship It!

- Dmitriy Shirchenko


On Jan. 29, 2016, 8:17 p.m., Kunal Thakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42975/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 8:17 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Dmitriy Shirchenko, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> The scheduler is unable to start when one of the parameters contains spaces. The -thermos-executor-flags param is a string and it doesn't get passed along as a string if we don't surround the variable with quotes (http://unix.stackexchange.com/questions/131766/why-does-my-shell-script-choke-on-whitespace-or-other-special-characters)
> 
> Also, added the rbt files to allow posting CRs from this repo
> 
> 
> Diffs
> -----
> 
>   .gitignore 81746232328d6bc4d448a0ce4654174d86972263 
>   build-support/virtualenv PRE-CREATION 
>   rbt PRE-CREATION 
>   specs/debian/aurora-scheduler.init b280c75860bfdd878c409f282a675b1d52b08729 
> 
> Diff: https://reviews.apache.org/r/42975/diff/
> 
> 
> Testing
> -------
> 
> Built the artifacts and tested the new debian package by following the instructions in test/deb/debian-jessie.
> 
> To simulate the failure in the previous version, modify /etc/default/aurora-scheduler on the test vagrant box:
> 
> THERMOS_EXECUTOR_FLAGS="--enable-announcer --announcer-ensemble localhost:2181"
> 
> After replacing that line, restart the scheduler.
> sudo systemctl restart aurora-scheduler  (it should fail without this change)
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>


--===============1097203624445072127==--