Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CEF9318F7F for ; Thu, 28 Jan 2016 02:22:33 +0000 (UTC) Received: (qmail 76055 invoked by uid 500); 28 Jan 2016 02:22:33 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 76001 invoked by uid 500); 28 Jan 2016 02:22:33 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 75978 invoked by uid 99); 28 Jan 2016 02:22:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jan 2016 02:22:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E591F2894FB; Thu, 28 Jan 2016 02:22:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8767119652751380429==" MIME-Version: 1.0 Subject: Re: Review Request 42811: Remove deprecated fields made redundant by JobKey. From: Bill Farner To: Maxim Khutornenko , John Sirois Cc: Bill Farner , Aurora , Aurora ReviewBot Date: Thu, 28 Jan 2016 02:22:32 -0000 Message-ID: <20160128022232.25059.70202@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Bill Farner X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42811/ X-Sender: Bill Farner References: <20160126190415.25059.61269@reviews.apache.org> In-Reply-To: <20160126190415.25059.61269@reviews.apache.org> Reply-To: Bill Farner X-ReviewRequest-Repository: aurora --===============8767119652751380429== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42811/ ----------------------------------------------------------- (Updated Jan. 27, 2016, 6:22 p.m.) Review request for Aurora, John Sirois and Maxim Khutornenko. Changes ------- rebase Bugs: AURORA-1598 https://issues.apache.org/jira/browse/AURORA-1598 Repository: aurora Description ------- Despite the previous effort to decouple from these fields in advance, this patch is still pretty big. I could have broken this one up, but i think it's better as an atom in case revert becomes necessary. Diffs (updated) ----- NEWS 29702d581bced316b313c5caa350de975a8bf428 api/src/main/thrift/org/apache/aurora/gen/api.thrift 95313a01db06f93e6fedb001df3d918f7a698a86 src/main/java/org/apache/aurora/scheduler/base/Query.java fbadfd3173c3b70deaac5bb96b73f29283b4d6fa src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 02ba1e3099ea5e1c4422e5b663b937365e1deb22 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java e4dbf06f41dddcbfb14521f8ceb9406b967713ee src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 16f2cb143469974efe4dc191c13788d8b8e21c57 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 6767024bb4cbf8f1b4cdcc5a7a0d0e99687785b0 src/main/python/apache/aurora/admin/admin.py b68f546b5710b373ffd1fc25b2d2096cc1b9981d src/main/python/apache/aurora/client/api/sla.py 5855685bda7188c55432dc6f1ad3c676a38309da src/main/python/apache/aurora/client/cli/jobs.py deba3a9026384e5bd436e611ab5b5ae3afc1cfcc src/main/python/apache/aurora/client/cli/task.py b722cd808c1bd0eaaa233a93381685d0e511e742 src/main/python/apache/aurora/config/thrift.py b40a7fdfa63eaf18d9a85f62eec5aa717a7e7d91 src/main/python/apache/aurora/executor/common/announcer.py c89cf4caa0df1a26a0839d7ef1b2b6f2e0ee0c82 src/main/python/apache/aurora/executor/common/sandbox.py d4c366e5deba1b03d1727dcc06e41661fff6c2ee src/main/resources/org/apache/aurora/scheduler/storage/db/CronJobMapper.xml ee603f42ce58e2cc73e4648f0c2f084d338c235b src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml 4e8966dc29689573a5ee3ba4c29392c3a7d14208 src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml db6c642522c422946eb3933859a2c3415e684cfe src/main/resources/scheduler/assets/js/controllers.js dff6645ea030500fb82baa68f0d971503ada1bce src/main/resources/scheduler/assets/js/services.js f9e8580d2db7b5418e8a89c8547a65a523c1a009 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 317506eb01457f8eee013fed40f16895369c660f src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 3ce78e355368acb539cd374638be665535bbfd4a src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java ef9aae11a9fcecf099241817528dbf2213515802 src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java ef20641b056a38d3f816acf476dd3e6f12f22ce0 src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java 22a6b43c97f6b0d2294d9cda218cf2889838f1c9 src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0443bb3ad7350bc442463fd1d4c0b51ddb38301e src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java e456056c88074abb7ad7863d22775bf7e5eb2c74 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 0428c779eabd16fe88ee1e41150cc76e3731fe8d src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 4ad921149d437f5928e3d0087c869fe4d57b50b4 src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java 67fe14b2fa90f9577b8ccab1e2c7b9e8a82e74b6 src/test/python/apache/aurora/admin/test_admin.py e8da335c2d98d3338b48357c4eeac328e30f9d1a src/test/python/apache/aurora/client/api/test_api.py 1f041f42fcd5ee5d147afacd9c8f83aa3129fe47 src/test/python/apache/aurora/client/api/test_sla.py 674e7f8c9d5b327945a05ea1dd54c83e0b9ff78d src/test/python/apache/aurora/client/cli/test_status.py a75f15e99af97acb0af7e112e28c693a77f9eb24 src/test/python/apache/aurora/client/cli/util.py 7ae5886fc0298ccb3764b61c091e3bf1ccb7df74 src/test/python/apache/aurora/config/test_thrift.py 1bd745964b45b30014cabbef89949ac6221f148b src/test/python/apache/aurora/executor/common/test_announcer.py bb9e4b0bca40270b719eb47fd9d8f4ec8aabb665 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py c473808d3df6cfd44c3515f2b6dcf20b0efa1075 src/test/python/apache/aurora/executor/test_thermos_executor.py 32e8b9bad4803b2196716cbc6710366a8a8c01a3 Diff: https://reviews.apache.org/r/42811/diff/ Testing ------- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Bill Farner --===============8767119652751380429==--