Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DB504188A4 for ; Tue, 26 Jan 2016 19:26:17 +0000 (UTC) Received: (qmail 4845 invoked by uid 500); 26 Jan 2016 19:26:17 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 4789 invoked by uid 500); 26 Jan 2016 19:26:17 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 4759 invoked by uid 99); 26 Jan 2016 19:26:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jan 2016 19:26:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0DC7D288D8E; Tue, 26 Jan 2016 19:26:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4673536068562471161==" MIME-Version: 1.0 Subject: Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields. From: John Sirois To: Bill Farner , Dmitriy Shirchenko , Maxim Khutornenko , Joshua Cohen Cc: Aurora , John Sirois Date: Tue, 26 Jan 2016 19:26:17 -0000 Message-ID: <20160126192617.25059.78711@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: John Sirois X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42816/ X-Sender: John Sirois References: <20160126191351.12173.43303@reviews.apache.org> In-Reply-To: <20160126191351.12173.43303@reviews.apache.org> Reply-To: John Sirois X-ReviewRequest-Repository: aurora --===============4673536068562471161== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42816/ ----------------------------------------------------------- (Updated Jan. 26, 2016, 12:26 p.m.) Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner. Changes ------- Kill more unused cruft from health check config validation removal. src/main/python/apache/aurora/client/config.py | 9 --------- 1 file changed, 9 deletions(-) Bugs: AURORA-1552 and AURORA-1563 https://issues.apache.org/jira/browse/AURORA-1552 https://issues.apache.org/jira/browse/AURORA-1563 Repository: aurora Description ------- Remove `endpoint`, `expected_response` and `expected_response_code` which were all deprecated in Aurora 0.11.0 in favor of the same-named fields in `HttpHealthChecker`. This also removes health check validation in the client in favor of leveraging the pystachio schema. The one difference this allows for is an empty string for the `ShellHealthChecker.shell_command`. Since an empty string is a valid shell command (equivalent to `true`), this simplification seems justified. NEWS | 3 ++ docs/configuration-reference.md | 3 -- src/main/python/apache/aurora/client/config.py | 31 ------------------ src/main/python/apache/aurora/config/schema/base.py | 5 +-- src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++------- src/test/python/apache/aurora/client/test_config.py | 88 -------------------------------------------------- 6 files changed, 9 insertions(+), 138 deletions(-) Diffs (updated) ----- NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81 src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2 src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85 src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4 src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9 Diff: https://reviews.apache.org/r/42816/diff/ Testing ------- Locally green: ``` ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois --===============4673536068562471161==--