Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4F0B1180C3 for ; Mon, 25 Jan 2016 22:43:36 +0000 (UTC) Received: (qmail 50552 invoked by uid 500); 25 Jan 2016 22:43:36 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 50496 invoked by uid 500); 25 Jan 2016 22:43:36 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 50479 invoked by uid 99); 25 Jan 2016 22:43:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jan 2016 22:43:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 78E30288B24; Mon, 25 Jan 2016 22:43:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8623469675628509298==" MIME-Version: 1.0 Subject: Re: Review Request 42749: [2/3] Add an annotation processor to generate db views. From: John Sirois To: Aurora , John Sirois Date: Mon, 25 Jan 2016 22:43:35 -0000 Message-ID: <20160125224335.12172.12203@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: John Sirois X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42749/ X-Sender: John Sirois References: <20160125224304.12172.41929@reviews.apache.org> In-Reply-To: <20160125224304.12172.41929@reviews.apache.org> X-ReviewBoard-Diff-For: mutablePeerGen/src/main/resources/META-INF/services/javax.annotation.processing.Processor X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/PrimitiveSetField X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/PrimitiveField X-ReviewBoard-Diff-For: mutablePeerGen/src/test/java/org/apache/aurora/storage/db/mybatis/peer/MutablePeerProcessorTest.java X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutableThriftSetField X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/PrimitiveMapField X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/ThriftSetField X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/ThriftListField X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/PreExistingPeer X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutableThriftField X-ReviewBoard-Diff-For: mutablePeerGen/src/main/java/org/apache/aurora/storage/db/mybatis/peer/MutablePeerProcessor.java X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/MultipleThriftAnnotationsContainer X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutableMultipleThriftAnnotationsContainer X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutablePrimitiveListField X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/MultipleThriftAnnotations X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutablePrimitiveMapField X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutablePreExistingPeerThriftField X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutableMultipleThriftAnnotations X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutablePrimitiveSetField X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/ThriftField X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutableThriftListField X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/ThriftMapField X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/PrimitiveListField X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutablePrimitiveField X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/artisinal/Peer X-ReviewBoard-Diff-For: mutablePeerGen/src/test/resources/org/apache/aurora/test/PreExistingPeerThriftField Reply-To: John Sirois X-ReviewRequest-Repository: aurora --===============8623469675628509298== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42749/#review116201 ----------------------------------------------------------- NB: Please hold off on review pending an email to dev@ explaining this 3 RB proposal. - John Sirois On Jan. 25, 2016, 3:43 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42749/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2016, 3:43 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > This processor automates the process of generating mutable "view" peers > that are both capable of being hydrated by MyBatis via private field > injection, and producing an immutable thrift peer graph once hydrated. > > .gitignore | 3 + > build.gradle | 28 +++- > mutablePeerGen/src/main/java/org/apache/aurora/storage/db/mybatis/peer/MutablePeerProcessor.java | 401 ++++++++++++++++++++++++++++++++++++++++++++++++++ > mutablePeerGen/src/main/resources/META-INF/services/javax.annotation.processing.Processor | 1 + > mutablePeerGen/src/test/java/org/apache/aurora/storage/db/mybatis/peer/MutablePeerProcessorTest.java | 155 +++++++++++++++++++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/MultipleThriftAnnotations | 69 +++++++++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/MultipleThriftAnnotationsContainer | 71 +++++++++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/PreExistingPeer | 67 +++++++++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/PreExistingPeerThriftField | 66 +++++++++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/PrimitiveField | 65 ++++++++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/PrimitiveListField | 67 +++++++++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/PrimitiveMapField | 68 +++++++++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/PrimitiveSetField | 67 +++++++++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/ThriftField | 64 ++++++++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/ThriftListField | 65 ++++++++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/ThriftMapField | 66 +++++++++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/ThriftSetField | 64 ++++++++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutableMultipleThriftAnnotations | 16 ++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutableMultipleThriftAnnotationsContainer | 16 ++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutablePreExistingPeerThriftField | 17 +++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutablePrimitiveField | 16 ++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutablePrimitiveListField | 17 +++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutablePrimitiveMapField | 17 +++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutablePrimitiveSetField | 17 +++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutableThriftField | 16 ++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutableThriftListField | 20 +++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutableThriftSetField | 20 +++ > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/artisinal/Peer | 9 ++ > settings.gradle | 2 +- > 29 files changed, 1568 insertions(+), 2 deletions(-) > > > Diffs > ----- > > mutablePeerGen/src/main/java/org/apache/aurora/storage/db/mybatis/peer/MutablePeerProcessor.java PRE-CREATION > mutablePeerGen/src/main/resources/META-INF/services/javax.annotation.processing.Processor PRE-CREATION > mutablePeerGen/src/test/java/org/apache/aurora/storage/db/mybatis/peer/MutablePeerProcessorTest.java PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/MultipleThriftAnnotations PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/MultipleThriftAnnotationsContainer PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/PreExistingPeer PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/PreExistingPeerThriftField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/PrimitiveField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/PrimitiveListField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/PrimitiveMapField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/PrimitiveSetField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/ThriftField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/ThriftListField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/ThriftMapField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/ThriftSetField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutableMultipleThriftAnnotations PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutableMultipleThriftAnnotationsContainer PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutablePreExistingPeerThriftField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutablePrimitiveField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutablePrimitiveListField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutablePrimitiveMapField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutablePrimitiveSetField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutableThriftField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutableThriftListField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/MutableThriftSetField PRE-CREATION > mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/artisinal/Peer PRE-CREATION > > Diff: https://reviews.apache.org/r/42749/diff/ > > > Testing > ------- > > Locally green: `./gradlew -Pq test` > > > Thanks, > > John Sirois > > --===============8623469675628509298==--