Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 20B2918C31 for ; Fri, 22 Jan 2016 21:33:15 +0000 (UTC) Received: (qmail 85808 invoked by uid 500); 22 Jan 2016 21:33:15 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 85757 invoked by uid 500); 22 Jan 2016 21:33:15 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 85726 invoked by uid 99); 22 Jan 2016 21:33:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jan 2016 21:33:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 674892817F8; Fri, 22 Jan 2016 21:33:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6635096543482237115==" MIME-Version: 1.0 Subject: Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks. From: Maxim Khutornenko To: Maxim Khutornenko , John Sirois Cc: Bill Farner , Aurora Date: Fri, 22 Jan 2016 21:33:14 -0000 Message-ID: <20160122213314.32314.66938@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Maxim Khutornenko X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42646/ In-Reply-To: <20160122212121.32314.36907@reviews.apache.org> X-Sender: Maxim Khutornenko X-ReviewBoard-ShipIt: 1 References: <20160122212121.32314.36907@reviews.apache.org> X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java X-ReviewBoard-ShipIt-Only: 1 Reply-To: Maxim Khutornenko X-ReviewRequest-Repository: aurora --===============6635096543482237115== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42646/#review115936 ----------------------------------------------------------- Ship it! Ship It! - Maxim Khutornenko On Jan. 22, 2016, 9:21 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42646/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 9:21 p.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > Related to a comment i made in https://reviews.apache.org/r/42628/, StorageBackfill was the only call site for `Storage.Mutable.mutateTasks`. As you can see from the patch, there's a lot that crumbles with it. > > Since it doesn't show in the patch, StorageBackfill was only filling the `TaskConfig.job` field in tasks and cron jobs: > https://github.com/apache/aurora/blob/9ed81a7db58f6a7cb308c8ac6a545705351c8c0e/src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java#L72 > > This backfill has been in place since `0.6.0-incubating` and should be safe to remove. > https://github.com/apache/aurora/commit/18ae0ab9696e3565cf57f6a2550c61142e76bee5#diff-74fad6db735428c9b72017b9097bb0c1L124 > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 0d3874e9632952c54ef5ae9aba78638e47c87056 > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 376f48545eb860aad5afa028d3b96d04acc08377 > src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 609a6242e8918bf4a044e6e5e2c8dfe4b900192e > src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 4e4f8d2c0f237c4480abe101835176f7d69958db > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 43fda1d001f52f916b8a6d75fcdb74d4280eaa41 > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 728353116c8892c015a6443d8db09ba241b32230 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 8fd024a460cd948dab703b99788b1ed2d6c43bc3 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 9fb8aad5d1c0412efc6d1176e543321ebe503e03 > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 1ac41d18fd9d603c4c342f9635e116bfd055f858 > src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 2570464c85630a55d3e6c8653fc0307d54504e15 > src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java 3c4e2bd5eefc141a5d2c5d0e56881899816652f8 > > Diff: https://reviews.apache.org/r/42646/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============6635096543482237115==--