Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 77ADE184CA for ; Thu, 21 Jan 2016 18:56:12 +0000 (UTC) Received: (qmail 90644 invoked by uid 500); 21 Jan 2016 18:56:12 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 90586 invoked by uid 500); 21 Jan 2016 18:56:12 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 90559 invoked by uid 99); 21 Jan 2016 18:56:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jan 2016 18:56:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C9ADD282B3C; Thu, 21 Jan 2016 18:56:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3664228059244336795==" MIME-Version: 1.0 Subject: Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure. From: "John Sirois" To: "Maxim Khutornenko" , "John Sirois" Cc: "Zameer Manji" , "Aurora" Date: Thu, 21 Jan 2016 18:56:10 -0000 Message-ID: <20160121185610.32039.90476@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "John Sirois" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42332/ X-Sender: "John Sirois" References: <20160120233946.7986.54787@reviews.apache.org> In-Reply-To: <20160120233946.7986.54787@reviews.apache.org> Reply-To: "John Sirois" X-ReviewRequest-Repository: aurora --===============3664228059244336795== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 20, 2016, 4:39 p.m., John Sirois wrote: > > Ship It! As Maxim points out below, the current `run` will consume a thread, so ship-it retracted! - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/#review115524 ----------------------------------------------------------- On Jan. 20, 2016, 3:39 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42332/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 3:39 p.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Bugs: AURORA-1582 > https://issues.apache.org/jira/browse/AURORA-1582 > > > Repository: aurora > > > Description > ------- > > Task pruning is key to operating a large cluster and failure to prune should trigger shutdown to prevent unbounded growth of storage. This patch turns `TaskHistoryPruner` into a service which propagates failure from failed pruning attempts towards the `ServiceManager`. Also completing a TODO which removes a test for behaviour that is very awkward to test for. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java 735199ac1ccccab343c24471890aa330d6635c26 > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 2064089937f5178b1413d386a312f4173a0e35fb > src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java 295960f13693c6ba0d7075a8ef7f9680a91ae69d > > Diff: https://reviews.apache.org/r/42332/diff/ > > > Testing > ------- > > ./gradlew build -Pq > e2e tests > > > Thanks, > > Zameer Manji > > --===============3664228059244336795==--