Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1C64818D5C for ; Fri, 15 Jan 2016 00:07:00 +0000 (UTC) Received: (qmail 28779 invoked by uid 500); 15 Jan 2016 00:07:00 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 28717 invoked by uid 500); 15 Jan 2016 00:07:00 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 28693 invoked by uid 99); 15 Jan 2016 00:06:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jan 2016 00:06:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EB85C2811AA; Fri, 15 Jan 2016 00:06:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0702586294822026033==" MIME-Version: 1.0 Subject: Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor. From: "John Sirois" To: "Maxim Khutornenko" , "John Sirois" Cc: "Zameer Manji" , "Aurora" Date: Fri, 15 Jan 2016 00:06:58 -0000 Message-ID: <20160115000658.26792.21322@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "John Sirois" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42328/ X-Sender: "John Sirois" References: <20160114235828.26793.73817@reviews.apache.org> In-Reply-To: <20160114235828.26793.73817@reviews.apache.org> Reply-To: "John Sirois" X-ReviewRequest-Repository: aurora --===============0702586294822026033== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42328/#review114611 ----------------------------------------------------------- Ship it! Ship It! - John Sirois On Jan. 14, 2016, 4:58 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42328/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 4:58 p.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Bugs: AURORA-1582 > https://issues.apache.org/jira/browse/AURORA-1582 > > > Repository: aurora > > > Description > ------- > > Add metric "async_executor_uncaught_exceptions" for tracking uncaught exceptions in async executor. > > > Diffs > ----- > > NEWS 809077fe6f689e726204519f93fdabb89a4bb5e5 > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 5facc048bc21adb124cb761647553afa9f8ab724 > > Diff: https://reviews.apache.org/r/42328/diff/ > > > Testing > ------- > > > Thanks, > > Zameer Manji > > --===============0702586294822026033==--