Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8DB38186A2 for ; Thu, 14 Jan 2016 21:35:51 +0000 (UTC) Received: (qmail 17506 invoked by uid 500); 14 Jan 2016 21:35:51 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 17461 invoked by uid 500); 14 Jan 2016 21:35:51 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 17433 invoked by uid 99); 14 Jan 2016 21:35:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jan 2016 21:35:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8D44028119A; Thu, 14 Jan 2016 21:35:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1305704070718928680==" MIME-Version: 1.0 Subject: Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters. From: "Zameer Manji" To: "Joshua Cohen" , "Maxim Khutornenko" , "Zameer Manji" Cc: "Amol Deshmukh" , "Aurora" Date: Thu, 14 Jan 2016 21:35:50 -0000 Message-ID: <20160114213550.26793.98417@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42046/ X-Sender: "Zameer Manji" References: <20160114211100.26792.95914@reviews.apache.org> In-Reply-To: <20160114211100.26792.95914@reviews.apache.org> Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora --===============1305704070718928680== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42046/#review114580 ----------------------------------------------------------- Ship it! Ship It! - Zameer Manji On Jan. 14, 2016, 1:10 p.m., Amol Deshmukh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42046/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 1:10 p.m.) > > > Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji. > > > Bugs: AURORA-1576 > https://issues.apache.org/jira/browse/AURORA-1576 > > > Repository: aurora > > > Description > ------- > > Allow for plugging in cli-configurable filters that are invoked post shiro filters. > > > Diffs > ----- > > NEWS acaff9eb2ab184b0ef750f8b8a00c20131997f6b > docs/security.md f9b60e9afa3280dc132067c5167f624c34ade66f > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java 4b6a872737e5934394e9511af7b6bd96c6034e72 > src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java ac92117e14c105bec74e49d8e80eb56008237abf > > Diff: https://reviews.apache.org/r/42046/diff/ > > > Testing > ------- > > Unit tests: > ``` > $ ./gradlew clean test > ... > BUILD SUCCESSFUL > > Total time: 3 mins 24.616 secs > ``` > > End to end tests: > ``` > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ... > > *** OK (All tests passed) *** > > aurora-scheduler-kerberos stop/waiting > aurora-scheduler start/running, process 15362 > + RETCODE=0 > + restore_netrc > + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc > + true > Connection to 127.0.0.1 closed. > > ``` > > > Thanks, > > Amol Deshmukh > > --===============1305704070718928680==--