Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6B096183F3 for ; Thu, 14 Jan 2016 01:39:27 +0000 (UTC) Received: (qmail 79436 invoked by uid 500); 14 Jan 2016 01:39:27 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 79382 invoked by uid 500); 14 Jan 2016 01:39:27 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 79349 invoked by uid 99); 14 Jan 2016 01:39:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jan 2016 01:39:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4CC99280FD7; Thu, 14 Jan 2016 01:39:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1150160217548847655==" MIME-Version: 1.0 Subject: Re: Review Request 42126: New class to allocate resources of multiple roles from offer. From: "Zhitao Li" To: "Bill Farner" , "Maxim Khutornenko" , "Dmitriy Shirchenko" Cc: "Zhitao Li" , "Aurora" , "Joshua Cohen" , "John Sirois" , "Aurora ReviewBot" Date: Thu, 14 Jan 2016 01:39:26 -0000 Message-ID: <20160114013926.26792.10291@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Zhitao Li" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42126/ X-Sender: "Zhitao Li" References: <20160113235021.26386.74226@reviews.apache.org> In-Reply-To: <20160113235021.26386.74226@reviews.apache.org> Reply-To: "Zhitao Li" X-ReviewRequest-Repository: aurora --===============1150160217548847655== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/ ----------------------------------------------------------- (Updated Jan. 14, 2016, 1:39 a.m.) Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner. Changes ------- 1. Better helper message; 2. Remove commented out test code; 3. Move all `static final` things to top. Bugs: AURORA-1109 https://issues.apache.org/jira/browse/AURORA-1109 Repository: aurora Description ------- This review is a prototype for introducing multiple role support in Aurora. This creates a new class OfferAllocation, which allcoates resources to resources field in TaskInfo and ExecutorInfo from an offer. Current implementation prefers reserved resources over shared resources ('*' role) if both are present Several caveats: 1. This performs the allocate after scheduling decision in TaskAssigner.maybeAssign is done, which leaves possibility of inconsistency and late failure. Diffs (updated) ----- NEWS acaff9eb2ab184b0ef750f8b8a00c20131997f6b src/main/java/org/apache/aurora/scheduler/AcceptedOffer.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 7c3d681c216b78eeecebbe950186e5a79c6fe982 src/main/java/org/apache/aurora/scheduler/Resources.java db422a959ee7b982c2a44323de41ad75d1a40754 src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 2255dd407cd1810c7df5baf17cfa85f79bfffeb8 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 8fdadda67478bb3110aa442b7d78493cf9c3edb4 src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 7e8e456e288986eb0ce92a123b294e1e25d8ed18 src/test/java/org/apache/aurora/scheduler/AcceptedOfferTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java e4ae943303823ac4bfbe999ed22f5999484462d8 src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java 33149ab415292eff04f38b61f2b1d1eac79f347a src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java a5793bffabf4e5d6195b1b99f2363d241c0cecf9 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 3cbe9acd75def14ae2e0986914ba621fb164b3e4 Diff: https://reviews.apache.org/r/42126/diff/ Testing ------- 1. Unit tested with old and new tests; 2. vagrant integration tests: I manually separate out the vagrant box's cpu and memory between 'aurora-test' role and '*' and verified that jobs can still be launched (I can post the vagrant change in another follow upon request). Thanks, Zhitao Li --===============1150160217548847655==--