Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6B2BB18199 for ; Mon, 11 Jan 2016 19:32:11 +0000 (UTC) Received: (qmail 48485 invoked by uid 500); 11 Jan 2016 19:32:11 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 48424 invoked by uid 500); 11 Jan 2016 19:32:11 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 48391 invoked by uid 99); 11 Jan 2016 19:32:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jan 2016 19:32:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ADBD5280621; Mon, 11 Jan 2016 19:32:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3574269602069747008==" MIME-Version: 1.0 Subject: Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag. From: "George Sirois" To: "Joshua Cohen" , "Bill Farner" Cc: "Aurora ReviewBot" , "Stephan Erb" , "George Sirois" , "Aurora" Date: Mon, 11 Jan 2016 19:32:10 -0000 Message-ID: <20160111193210.26793.18816@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "George Sirois" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42077/ X-Sender: "George Sirois" References: <20160108182857.1692.53607@reviews.apache.org> In-Reply-To: <20160108182857.1692.53607@reviews.apache.org> Reply-To: "George Sirois" X-ReviewRequest-Repository: aurora --===============3574269602069747008== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42077/ ----------------------------------------------------------- (Updated Jan. 11, 2016, 7:32 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Changes ------- Made documentation more explicit + a bit more test cleanup. Should be good for review now. Bugs: AURORA-1575 https://issues.apache.org/jira/browse/AURORA-1575 Repository: aurora Description ------- This flag allows cluster administrators to set arbitrary Docker parameters which will apply to all jobs. Also cleans up some of the existing unit tests around task config. Diffs (updated) ----- README.md f3b23247cf3f7e550c1714b4fb8227a2baab3b41 commons/src/main/java/org/apache/aurora/common/args/parsers/MultimapParser.java PRE-CREATION docs/deploying-aurora-scheduler.md 8a1e68e5d54e9b8b66139bfc731563668584fa77 src/main/java/org/apache/aurora/scheduler/app/AppModule.java 4eee8e31a4ccd25ba4a5bcb60b67c79979c3b9b0 src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java d7f3c60d383cf10afb0c0fcf4fe29972b183458c src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 05e8b714043dea89039ce9a1fc4b32c65ab15fe4 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java f3b62cc957186bc9673060830572bc1cc073ac49 Diff: https://reviews.apache.org/r/42077/diff/ Testing ------- ./build-support/jenkins/build.sh Thanks, George Sirois --===============3574269602069747008==--