Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============6346221841084355472=="
MIME-Version: 1.0
Subject: Re: Review Request 41809: Allow custom announce path
From: "Aurora ReviewBot" <wfarner@apache.org>
To: "Joshua Cohen" <jcohen@apache.org>, "Bill Farner" <wfarner@apache.org>
Cc: "Aurora" <reviews@aurora.apache.org>, "Kunal Thakar" <kunalt@uber.com>,
 "Aurora ReviewBot" <wfarner@apache.org>
Date: Tue, 05 Jan 2016 20:24:32 -0000
Message-ID: <20160105202432.26044.37014@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Aurora ReviewBot" <noreply@reviews.apache.org>
References: <20160105195134.26044.76690@reviews.apache.org>
In-Reply-To: <20160105195134.26044.76690@reviews.apache.org>
Reply-To: "Aurora ReviewBot" <wfarner@apache.org>

--===============6346221841084355472==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/#review112921
-----------------------------------------------------------


Master (b9d9ee3) is red with this patch.
  ./build-support/jenkins/build.sh

virtualenv-12.1.1/virtualenv_embedded/activate.ps1
virtualenv-12.1.1/virtualenv_embedded/activate.sh
virtualenv-12.1.1/virtualenv_embedded/activate_this.py
virtualenv-12.1.1/virtualenv_embedded/deactivate.bat
virtualenv-12.1.1/virtualenv_embedded/distutils-init.py
virtualenv-12.1.1/virtualenv_embedded/distutils.cfg
virtualenv-12.1.1/virtualenv_embedded/site.py
virtualenv-12.1.1/virtualenv_support/
virtualenv-12.1.1/virtualenv_support/__init__.py
virtualenv-12.1.1/virtualenv_support/pip-6.1.1-py2.py3-none-any.whl
virtualenv-12.1.1/virtualenv_support/setuptools-15.0-py2.py3-none-any.whl
+ touch virtualenv-12.1.1/BOOTSTRAPPED
+ popd
~/jenkins-slave/workspace/AuroraBot
+ exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-12.1.1/virtualenv.py /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv
New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7
Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python
Installing setuptools, pip...done.
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:79: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
You are using pip version 6.1.1, however version 7.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Collecting isort==4.0.0
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:79: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Using cached isort-4.0.0-py2.py3-none-any.whl
Installing collected packages: isort
Successfully installed isort-4.0.0
ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/announcer.py Imports are incorrectly sorted.
--- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/announcer.py:before	2016-01-05 20:19:12.457020
+++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/announcer.py:after	2016-01-05 20:24:31.525505
@@ -20,7 +20,7 @@
 from kazoo.client import KazooClient
 from kazoo.retry import KazooRetry
 from mesos.interface import mesos_pb2
-from twitter.common import log, app
+from twitter.common import app, log
 from twitter.common.concurrent.deferred import defer
 from twitter.common.exceptions import ExceptionalThread
 from twitter.common.metrics import LambdaGauge, Observable


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 5, 2016, 7:51 p.m., Kunal Thakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41809/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 7:51 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Allow custom announce path
> 
> Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b 
>   src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec 
>   src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955 
> 
> Diff: https://reviews.apache.org/r/41809/diff/
> 
> 
> Testing
> -------
> 
> Ran tests ./build-support/jenkins/build.sh
> Manually tested the changes in vagrant.
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>


--===============6346221841084355472==--