Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A13A618F84 for ; Sun, 3 Jan 2016 15:36:01 +0000 (UTC) Received: (qmail 39214 invoked by uid 500); 3 Jan 2016 15:36:01 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 39158 invoked by uid 500); 3 Jan 2016 15:36:01 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 39141 invoked by uid 99); 3 Jan 2016 15:36:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jan 2016 15:36:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2E09D2974AA; Sun, 3 Jan 2016 15:36:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1124585624818247723==" MIME-Version: 1.0 Subject: Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff. From: "Aurora ReviewBot" To: "Bill Farner" , "Stephan Erb" Cc: "Aurora ReviewBot" , "Tony Dong" , "Aurora" Date: Sun, 03 Jan 2016 15:36:00 -0000 Message-ID: <20160103153600.26043.48695@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41717/ X-Sender: "Aurora ReviewBot" References: <20160103152422.26043.64298@reviews.apache.org> In-Reply-To: <20160103152422.26043.64298@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora --===============1124585624818247723== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41717/#review112458 ----------------------------------------------------------- Master (4a9f2ff) is red with this patch. ./build-support/jenkins/build.sh :buildSrc:check UP-TO-DATE :buildSrc:build :commons:assemble :commons:licenseMain Unknown file extension: commons/src/main/resources/org/apache/aurora/common/net/http/handlers/thrift.st Unknown file extension: commons/src/main/resources/org/apache/aurora/common/net/http/handlers/logconfig.st :commons:licenseMain UP-TO-DATE :commons:licenseTest Unknown file extension: commons/src/test/resources/org/apache/aurora/common/util/templating/template.st :commons:licenseTest UP-TO-DATE :commons:license UP-TO-DATE :commons:compileTestJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/classes/test/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2 Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/classes/test/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: /home/jenkins/jenkins-slave/workspace/AuroraBot/commons/src/test/java/org/apache/aurora/common/collections/Iterables2Test.java uses unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. :commons:processTestResources :commons:testClasses :commons:test org.apache.aurora.common.util.TruncatedBinaryBackoffTest > testCalculateBackoffStop FAILED java.lang.AssertionError at TruncatedBinaryBackoffTest.java:96 197 tests completed, 1 failed :commons:test FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':commons:test'. > There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/reports/tests/index.html * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 4 mins 45.575 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 3, 2016, 3:24 p.m., Tony Dong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41717/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2016, 3:24 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Add jittering to TruncatedBinaryBackoff. > > > Diffs > ----- > > commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985 > commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java fd74b9f37c6cc24c7ea1cb239ba6354661d931e2 > commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java 127a60331f8560d98733bd16654087f840abef72 > src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java fbc589e9a7592cce6d92c4e987cde2e056406c3a > src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 291bf5f0baefef6dd10d19ec89e173ce495e6380 > > Diff: https://reviews.apache.org/r/41717/diff/ > > > Testing > ------- > > > Thanks, > > Tony Dong > > --===============1124585624818247723==--