Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 695A618F95 for ; Fri, 1 Jan 2016 23:12:14 +0000 (UTC) Received: (qmail 75366 invoked by uid 500); 1 Jan 2016 23:12:14 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 75303 invoked by uid 500); 1 Jan 2016 23:12:14 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 75287 invoked by uid 99); 1 Jan 2016 23:12:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jan 2016 23:12:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7481A1CC2DA; Fri, 1 Jan 2016 23:12:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5834094513623989055==" MIME-Version: 1.0 Subject: Re: Review Request 41834: Simplify thrift service metadata. From: "Bill Farner" To: "Bill Farner" Cc: "John Sirois" , "Aurora" Date: Fri, 01 Jan 2016 23:12:12 -0000 Message-ID: <20160101231212.4181.38198@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41834/ X-Sender: "Bill Farner" References: <20151231203837.4182.67971@reviews.apache.org> In-Reply-To: <20151231203837.4182.67971@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora --===============5834094513623989055== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41834/#review112414 ----------------------------------------------------------- Ship it! Nice! I knew we would find a way to put that feature to good use :-) - Bill Farner On Dec. 31, 2015, 12:38 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41834/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2015, 12:38 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > This leverages java.lang.reflect.Parameter.getName as enabled by turning > on emission of parameter names in the debug info for aurora classfiles. > > The IDEA project config is also fixed up to do the same. > > build.gradle | 9 +++++++++ > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy | 2 ++ > src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java | 26 ++++++++++++-------------- > src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py | 40 ++++++++++------------------------------ > 4 files changed, 33 insertions(+), 44 deletions(-) > > > Diffs > ----- > > build.gradle 5ff10d90fa8f748b066faf1c4ec385b22dd883b4 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy 44cb723728fd4ca54961856202e15ae093fa1ca4 > src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java b889f9354228833ffd486c951957161d5da737c2 > src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 49cfa9fbaa5a8aeba973df142d8f29f6e37564b6 > > Diff: https://reviews.apache.org/r/41834/diff/ > > > Testing > ------- > > Locally green `./build-support/jenkins/build.sh` as well as a green run > of `ApiBetaTest` from within IDEA using `./gradlew idea` to gen a new > project. > > > Thanks, > > John Sirois > > --===============5834094513623989055==--