aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Staffin <ben...@gmail.com>
Subject Re: Review Request 42953: Improve --read-json to handle multi-job files
Date Fri, 29 Jan 2016 23:31:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42953/
-----------------------------------------------------------

(Updated Jan. 29, 2016, 3:31 p.m.)


Review request for Aurora.


Bugs: AURORA-1577
    https://issues.apache.org/jira/browse/AURORA-1577


Repository: aurora


Description (updated)
-------

Still handles the old --read-json behavior of expecting a single job,
but adds the ability to read files with a {"jobs": [job1, job2, ...]}
schema like the pystachio format.

Also adds --read-json to the `aurora config load` command, as it is
now useful there.

Json configs are now loaded in a way that is much closer to the
pystachio one, so the config loader will no longer ignore unknown
fields.

Fixes: AURORA-1577


Diffs
-----

  src/main/python/apache/aurora/client/cli/config.py 73b556266183bf17463881b87cda107d07d79d71

  src/main/python/apache/aurora/config/__init__.py 665e2cd08d4146e652b13bb82e04680315a1eebe

  src/main/python/apache/aurora/config/loader.py a967b9dca353f5a70c89abee5d45220a9593c01a

  src/test/python/apache/aurora/config/test_loader.py 9789255cb0280ef0d1a83cd8c1cf8fa3581553b5


Diff: https://reviews.apache.org/r/42953/diff/


Testing
-------


Thanks,

Benjamin Staffin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message